From c5be016b8dd2070e1bd754cdeda8ec8792f4aa8a Mon Sep 17 00:00:00 2001 From: Patrick Hopf <81010725+flowerthrower@users.noreply.github.com> Date: Wed, 26 Nov 2025 13:15:49 +0100 Subject: [PATCH 1/7] enable ignore by caller inputs --- .github/workflows/reusable-cpp-linter.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/reusable-cpp-linter.yml b/.github/workflows/reusable-cpp-linter.yml index a7890f4..ecd8516 100644 --- a/.github/workflows/reusable-cpp-linter.yml +++ b/.github/workflows/reusable-cpp-linter.yml @@ -46,6 +46,10 @@ on: description: "Packages to install in the Python virtual environment as a comma-separated list" default: "" type: string + cpp-linter-ignore-extra: + description: "Extra pipe-separated ignore globs for cpp-linter (e.g., 'plugin/**|subdir/third_party/**')" + default: "" + type: string jobs: lint: @@ -152,7 +156,11 @@ jobs: style: "" tidy-checks: "" version: ${{ inputs.clang-version }} - ignore: "build|!build/mlir/**|**/include|include" + ignore: ${{ format( + 'build|!build/mlir/**|**/include|include{0}{1}', + inputs.cpp-linter-ignore-extra != '' && '|' || '', + inputs.cpp-linter-ignore-extra + ) }} thread-comments: ${{ github.event_name == 'pull_request' && 'update' }} step-summary: true database: "build" From f9749ef824fc6231a0439d82faf66ca4c2ba6b56 Mon Sep 17 00:00:00 2001 From: flowerthrower Date: Wed, 26 Nov 2025 13:21:16 +0100 Subject: [PATCH 2/7] =?UTF-8?q?=E2=9C=A8=20Update=20CHANGELOG=20for=20vers?= =?UTF-8?q?ion=201.18.0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 33a910e..c0d7a02 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,12 @@ This project adheres to [Semantic Versioning], with the exception that minor rel ## [Unreleased] +## [1.17.4] - 2025-11-26 + +### Added + +- ✨ Add optional `cpp-linter-ignore-extra` input to allow ignoring additional files in C++ linter ([#241]) ([**@flowerthrower**]) + ## [1.17.3] - 2025-11-26 ### Fixed @@ -169,7 +175,8 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._ -[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD +[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.4...HEAD +[1.17.4]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.4 [1.17.3]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.3 [1.17.2]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.2 [1.17.1]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.1 @@ -192,6 +199,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._ [#255]: https://github.com/munich-quantum-toolkit/workflows/pull/255 [#254]: https://github.com/munich-quantum-toolkit/workflows/pull/254 [#247]: https://github.com/munich-quantum-toolkit/workflows/pull/247 +[#241]: https://github.com/munich-quantum-toolkit/workflows/pull/241 [#206]: https://github.com/munich-quantum-toolkit/workflows/pull/206 [#188]: https://github.com/munich-quantum-toolkit/workflows/pull/188 [#184]: https://github.com/munich-quantum-toolkit/workflows/pull/184 @@ -215,6 +223,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._ [**@burgholzer**]: https://github.com/burgholzer [**@ystade**]: https://github.com/ystade [**@denialhaag**]: https://github.com/denialhaag +[**@flowerthrower**]: https://github.com/flowerthrower From 4717c391d1d5dabd7e734ddb240fee5d3b239e29 Mon Sep 17 00:00:00 2001 From: flowerthrower Date: Wed, 26 Nov 2025 13:21:16 +0100 Subject: [PATCH 3/7] =?UTF-8?q?=F0=9F=90=8D=20Fix=20indentation=20in=20cpp?= =?UTF-8?q?-linter=20workflow=20to=20calm=20pre-commit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/reusable-cpp-linter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-cpp-linter.yml b/.github/workflows/reusable-cpp-linter.yml index ecd8516..6f43396 100644 --- a/.github/workflows/reusable-cpp-linter.yml +++ b/.github/workflows/reusable-cpp-linter.yml @@ -160,7 +160,7 @@ jobs: 'build|!build/mlir/**|**/include|include{0}{1}', inputs.cpp-linter-ignore-extra != '' && '|' || '', inputs.cpp-linter-ignore-extra - ) }} + ) }} thread-comments: ${{ github.event_name == 'pull_request' && 'update' }} step-summary: true database: "build" From 788980dc2fb28492958c94e5005db95a6805626b Mon Sep 17 00:00:00 2001 From: flowerthrower Date: Wed, 26 Nov 2025 10:05:53 +0100 Subject: [PATCH 4/7] =?UTF-8?q?=E2=9C=A8=20Update=20CHANGELOG=20for=20vers?= =?UTF-8?q?ion=201.17.3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0d7a02..c2a04a9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,14 +9,12 @@ This project adheres to [Semantic Versioning], with the exception that minor rel ## [Unreleased] -## [1.17.4] - 2025-11-26 +## [1.17.3] - 2025-11-26 ### Added - ✨ Add optional `cpp-linter-ignore-extra` input to allow ignoring additional files in C++ linter ([#241]) ([**@flowerthrower**]) -## [1.17.3] - 2025-11-26 - ### Fixed - 🐍🚨 Ensure a locked version of `ty` is used when enabled to guarantee stability ([#255]) ([**@burgholzer**]) @@ -175,8 +173,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._ -[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.4...HEAD -[1.17.4]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.4 +[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD [1.17.3]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.3 [1.17.2]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.2 [1.17.1]: https://github.com/munich-quantum-toolkit/workflows/releases/tag/v1.17.1 From aea15197d0f917f2a87f74f05180a0359cb0f3ac Mon Sep 17 00:00:00 2001 From: flowerthrower Date: Wed, 26 Nov 2025 13:31:12 +0100 Subject: [PATCH 5/7] =?UTF-8?q?=E2=9C=A8=20Updated=20upgrade=20guide?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: burgholzer --- UPGRADING.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/UPGRADING.md b/UPGRADING.md index 01bd230..1cabf7f 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -6,11 +6,25 @@ This document describes breaking changes and how to upgrade. For a complete list ## [1.17.3] +### Type checking with `ty` + This release fixes the `ty` linter workflow, which would always use the latest version of `ty` available on PyPI. As `ty` is still moving pretty fast and the latest version may not be stable yet, this was not ideal. This release changes the behavior to use the version of `ty` listed as a development dependency in `pyproject.toml`. If you have the `enable-ty` option set to `true` in your workflow configuration, you **must** add `ty` to your development dependencies or the workflow will fail. +### Additional customization for the C++ linter + +This release adds the optional `cpp-linter-ignore-extra` input to the `reusable-cpp-linter.yml` workflow. +This allows ignoring additional files in the C++ linter workflow by passing a pipe-separated list of globs. +For example, to ignore all files in the `plugin` directory and the `subdir/third_party` directory, you can use the following configuration: + +```yaml +uses: munich-quantum-toolkit/workflows/.github/workflows/reusable-cpp-linter.yml@v1.17.3 +with: + cpp-linter-ignore-extra: "plugin/**|subdir/third_party/**" +``` + ## [1.17.0] This release removes all CodeQL workflows because CodeQL is now run automatically by GitHub. @@ -166,7 +180,7 @@ Consider removing any `-G Ninja` flags from your CMake invocations under Windows -[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...HEAD +[unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD [1.17.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.16.0...v1.17.0 [1.16.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.15.0...v1.16.0 [1.15.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.14.0...v1.15.0 From 9212179784d51e752e099552f094c9da2500b84f Mon Sep 17 00:00:00 2001 From: Patrick Hopf <81010725+flowerthrower@users.noreply.github.com> Date: Wed, 26 Nov 2025 14:18:05 +0100 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: Daniel Haag <121057143+denialhaag@users.noreply.github.com> Signed-off-by: Patrick Hopf <81010725+flowerthrower@users.noreply.github.com> --- CHANGELOG.md | 1 + UPGRADING.md | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2a04a9..24b5e40 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning], with the exception that minor rel ## [Unreleased] ## [1.17.3] - 2025-11-26 +_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#1173)._ ### Added diff --git a/UPGRADING.md b/UPGRADING.md index 1cabf7f..20f3ddf 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -181,6 +181,7 @@ Consider removing any `-G Ninja` flags from your CMake invocations under Windows [unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD +[1.17.3]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...v1.17.3 [1.17.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.16.0...v1.17.0 [1.16.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.15.0...v1.16.0 [1.15.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.14.0...v1.15.0 From 522db10721529f4ac7a908b0af9154ca837b28f0 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 26 Nov 2025 13:18:14 +0000 Subject: [PATCH 7/7] =?UTF-8?q?=F0=9F=8E=A8=20pre-commit=20fixes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 24b5e40..e5d0be9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning], with the exception that minor rel ## [Unreleased] ## [1.17.3] - 2025-11-26 + _If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#1173)._ ### Added