Commit fcb1a7a
committed
Fix tremolo articulation mapping for individual string instruments
- Add missing tremolo articulation mappings to individual VIOLIN, VIOLA, VIOLONCELLO, and CONTRABASS
- Previously only *_SECTION variants had tremolo mappings, causing tremolo to fall back to default arco sound
- Individual instruments now correctly map tremolo to program 44 on their respective banks (20, 30, 40, 50)
- Fixes issue #21122: Multichannel instruments don't select correct midi preset for tremolo on SF2 fonts
Affected mappings:
- VIOLIN: Added Tremolo8th/16th/32nd/64th → midi::Program(20, 44)
- VIOLA: Added Tremolo8th/16th/32nd/64th → midi::Program(30, 44)
- VIOLONCELLO: Added Tremolo8th/16th/32nd/64th → midi::Program(40, 44)
- CONTRABASS: Added Tremolo8th/16th/32nd/64th → midi::Program(50, 44)
Now string instruments (violin, viola, violoncello, contrabass) correctly select tremolo MIDI presets when using SF2 soundfonts.
Changes made:
1. Updated soundmapping.h:
- Added missing tremolo articulation mappings for individual instruments
- VIOLIN: Bank 20, Program 44
- VIOLA: Bank 30, Program 44
- VIOLONCELLO: Bank 40, Program 44
- CONTRABASS: Bank 50, Program 44
Fixes: #211221 parent 2e84dba commit fcb1a7a
File tree
1 file changed
+19
-3
lines changed- src/framework/audio/engine/internal/synthesizers/fluidsynth
1 file changed
+19
-3
lines changedLines changed: 19 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
923 | 923 | | |
924 | 924 | | |
925 | 925 | | |
926 | | - | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
927 | 931 | | |
928 | 932 | | |
929 | 933 | | |
| |||
941 | 945 | | |
942 | 946 | | |
943 | 947 | | |
944 | | - | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
945 | 953 | | |
946 | 954 | | |
947 | 955 | | |
| |||
959 | 967 | | |
960 | 968 | | |
961 | 969 | | |
962 | | - | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
963 | 975 | | |
964 | 976 | | |
965 | 977 | | |
| |||
978 | 990 | | |
979 | 991 | | |
980 | 992 | | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
981 | 997 | | |
982 | 998 | | |
983 | 999 | | |
| |||
0 commit comments