Skip to content

Commit 8a63563

Browse files
authored
Merge pull request #82 from mutagen-io/no-network-dep-fix
sidecar: disable networking if no network dependencies are present
2 parents 3c59b77 + 810dc0e commit 8a63563

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

pkg/mutagen/liaison.go

+11-3
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,13 @@ func (l *Liaison) processProject(project *types.Project) error {
464464
}
465465
composeVersion := strings.TrimPrefix(versions.Compose, "v")
466466

467+
// If there are no network dependencies, then disable networking.
468+
var networkMode string
469+
if len(networkDependencies) == 0 {
470+
networkMode = "none"
471+
networkDependencies = nil
472+
}
473+
467474
// Create and record the Mutagen sidecar service definition. The service
468475
// configuration we generate here needs to match (as closely as possible)
469476
// those generated by projectOptions.toProject in Compose. In particular,
@@ -476,9 +483,10 @@ func (l *Liaison) processProject(project *types.Project) error {
476483
sidecarRoleLabelKey: sidecarRoleLabelValue,
477484
sidecarVersionLabelKey: mutagen.Version,
478485
},
479-
Networks: networkDependencies,
480-
Volumes: serviceVolumeDependencies,
481-
CapAdd: capabilities,
486+
NetworkMode: networkMode,
487+
Networks: networkDependencies,
488+
Volumes: serviceVolumeDependencies,
489+
CapAdd: capabilities,
482490
CustomLabels: types.Labels{
483491
api.ProjectLabel: project.Name,
484492
api.ServiceLabel: sidecarServiceName,

0 commit comments

Comments
 (0)