Use a machine-verified implementation of x_strlcpy()

Author: dtrebbien

.gitignore

@@ -19,3 +19,4 @@ x64
 /config.status
 Makefile
 /stamp-h1
+!/tests/string_utils_test/Makefile

tests/string_utils_test/Makefile

@@ -0,0 +1,8 @@
+string_utils_test: string_utils_test.o x_strlcpy.o
+	$(CXX) -o $@ string_utils_test.o x_strlcpy.o -lboost_unit_test_framework-mt -lstdc++
+
+string_utils_test.o: ../../string_utils.h ../../x_strlcpy.c
+	$(CXX) -c -o $@ -I ../.. string_utils_test.cpp
+
+x_strlcpy.o: ../../string_utils.h ../../x_strlcpy.c
+	$(CXX) -c -o $@ -I ../.. ../../x_strlcpy.c

x_strlcpy.c

@@ -1,30 +1,29 @@
 /* -*- coding: utf-8; tab-width: 2; c-basic-offset: 2; indent-tabs-mode: t -*- */
 
-// This code and all comments, written by Daniel Trebbien, are hereby entered into the Public Domain by their author.
+/* This code and all comments, written by Daniel Trebbien, are hereby entered into the Public Domain by their author. */
 
-#include <assert.h>
 #include <string.h>
 
 #include "string_utils.h"
 
+/* This implementation is machine-verified:
+   https://github.com/dtrebbien/verlibc/blob/daea83474b36dc251751d100d2ba347d1aa906d6/src/string/strlcpy.c */
 size_t x_strlcpy(char *__restrict dest, const char *__restrict src, size_t dest_len)
 {
 	if (dest_len == 0) {
 		return strlen(src);
 	} else {
 		char *const dest_str_end = dest + dest_len - 1;
 		char *__restrict d = dest;
+		const char *__restrict s = src;
 
-		while (d != dest_str_end)
-		{
-			if ((*d++ = *src++) == '\0') {
-				assert(*(src - 1) == '\0');
-				assert(*(d - 1) == '\0');
+		while (d != dest_str_end) {
+			if ((*d++ = *s++) == '\0') {
 				return (d - 1 - dest);
 			}
 		}
 
 		*d = '\0';
-		return (dest_len - 1) + strlen(src);
+		return (dest_len - 1) + strlen(s);
 	}
 }