error and return instead

thokra-nav · thokra-nav · commit 52f2b8e16c5f · 2025-03-17T11:11:10.000+01:00
diff --git a/internal/kubernetes/event/watcher.go b/internal/kubernetes/event/watcher.go
@@ -204,7 +204,8 @@ func (w *Watcher) watch(ctx context.Context, env string, client kubernetes.Inter
 			}
 		case event, ok := <-rescale.ResultChan():
 			if !ok {
-				continue
+				w.log.WithField("env", env).WithField("watcher", "rescale").Error("watching events returned closed channel")
+				return fmt.Errorf("watcher failed")
 			}
 			w.eventsCounter.Add(ctx, 1, metric.WithAttributes(
 				attribute.String("environment", string(env)),
@@ -242,7 +243,8 @@ func (w *Watcher) watch(ctx context.Context, env string, client kubernetes.Inter
 			})
 		case event, ok := <-killing.ResultChan():
 			if !ok {
-				continue
+				w.log.WithField("env", env).WithField("watcher", "rescale").Error("watching events returned closed channel")
+				return fmt.Errorf("watcher failed")
 			}
 
 			w.eventsCounter.Add(ctx, 1, metric.WithAttributes(

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,8 @@ func (w *Watcher) watch(ctx context.Context, env string, client kubernetes.Inter`
`204`	`204`	`}`
`205`	`205`	`case event, ok := <-rescale.ResultChan():`
`206`	`206`	`if !ok {`
`207`		`- continue`
	`207`	`+ w.log.WithField("env", env).WithField("watcher", "rescale").Error("watching events returned closed channel")`
	`208`	`+ return fmt.Errorf("watcher failed")`
`208`	`209`	`}`
`209`	`210`	`w.eventsCounter.Add(ctx, 1, metric.WithAttributes(`
`210`	`211`	`attribute.String("environment", string(env)),`
`@@ -242,7 +243,8 @@ func (w *Watcher) watch(ctx context.Context, env string, client kubernetes.Inter`
`242`	`243`	`})`
`243`	`244`	`case event, ok := <-killing.ResultChan():`
`244`	`245`	`if !ok {`
`245`		`- continue`
	`246`	`+ w.log.WithField("env", env).WithField("watcher", "rescale").Error("watching events returned closed channel")`
	`247`	`+ return fmt.Errorf("watcher failed")`
`246`	`248`	`}`
`247`	`249`
`248`	`250`	`w.eventsCounter.Add(ctx, 1, metric.WithAttributes(`