deprecated registry is now a warning

Co-authored-by: Johnny Horvi <[email protected]>
Co-authored-by: Thomas Krampl <[email protected]>

Author: 3 people

integration_tests/status_for_applications.lua

@@ -94,15 +94,15 @@ Test.gql("app with deprecated registry", function(t)
 						status = {
 							state = "NAIS",
 							errors = {
+								expectedMissingSBOM,
 								{
 									__typename = "WorkloadStatusDeprecatedRegistry",
-									level = "TODO",
+									level = "WARNING",
 									name = "app-name",
 									registry = "navikt",
 									repository = "",
 									tag = "latest",
 								},
-								expectedMissingSBOM,
 							},
 						},
 					},

integration_tests/status_for_jobs.lua

@@ -62,15 +62,15 @@ Test.gql("job with deprecated registry", function(t)
 						status = {
 							state = "NAIS",
 							errors = {
+								expectedMissingSBOM,
 								{
 									__typename = "WorkloadStatusDeprecatedRegistry",
-									level = "TODO",
+									level = "WARNING",
 									name = "app-name",
 									registry = "ghcr.io",
 									repository = "navikt",
 									tag = "latest",
 								},
-								expectedMissingSBOM,
 							},
 						},
 					},

internal/status/check_deprecated_registry.go

@@ -37,7 +37,7 @@ func (checkDeprecatedRegsitry) run(_ context.Context, w workload.Workload) Workl
 		repository = strings.Join(parts[1:len(parts)-1], "/")
 	}
 	return &WorkloadStatusDeprecatedRegistry{
-		Level:      WorkloadStatusErrorLevelTodo,
+		Level:      WorkloadStatusErrorLevelWarning,
 		Registry:   registry,
 		Name:       name,
 		Tag:        tag,