Add success messages for all retry.Do cases

Author: mortenlj

internal/pkg/application/application.go

@@ -64,6 +64,7 @@ func UpdateApplicationInstance(ctx context.Context, cfg *config.Config, instance
 			return nil, err
 		}
 
+		mgr.Logger.Info("application update applied", "name", cfg.ApplicationName)
 		return app, nil
 	})
 	if err != nil {
@@ -105,15 +106,13 @@ func UpdateApplicationUser(ctx context.Context, target *resolved.Instance, gcpPr
 			return retry.RetryableError(fmt.Errorf("user not up to date"))
 		}
 
+		mgr.Logger.Info("user is up to date, setting database password", "user", target.AppUsername)
 		return nil
 	})
-
 	if err != nil {
 		return err
 	}
 
-	mgr.Logger.Info("user is up to date, setting database password", "user", target.AppUsername)
-
 	return database.SetDatabasePassword(ctx, target.Name, target.AppUsername, target.AppPassword, gcpProject, mgr)
 }
 

internal/pkg/database/database.go

@@ -168,6 +168,7 @@ func getSqlUser(ctx context.Context, instance string, userName string, gcpProjec
 			}
 			return nil, err
 		}
+		mgr.Logger.Info("got Cloud SQL user", "user", userName)
 		return user, nil
 	})
 	if err != nil {

internal/pkg/instance/instance.go

@@ -150,6 +150,7 @@ func PrepareSourceInstance(ctx context.Context, source *resolved.Instance, targe
 			return err
 		}
 
+		mgr.Logger.Info("update of source instance applied")
 		return nil
 	})
 
@@ -216,6 +217,7 @@ func WaitForCnrmResourcesToGoAway(ctx context.Context, name string, mgr *common_
 					return retry.RetryableError(errors.New("resource still exists"))
 				}
 				if k8s_errors.IsNotFound(err) {
+					mgr.Logger.Info("resource has been deleted", "kind", r.kind)
 					return nil
 				}
 				logger.Warn("failed to get resource, retrying...", "kind", r.kind, "error", err.Error())
@@ -263,6 +265,8 @@ func PrepareTargetInstance(ctx context.Context, target *resolved.Instance, mgr *
 			}
 			return err
 		}
+
+		mgr.Logger.Info("update of target instance applied")
 		return nil
 	})
 	if err != nil {
@@ -312,6 +316,8 @@ func UpdateTargetInstanceAfterPromotion(ctx context.Context, target *resolved.In
 			}
 			return err
 		}
+
+		mgr.Logger.Info("update of target instance applied")
 		return nil
 	})
 	if err != nil {
@@ -382,6 +388,8 @@ func CleanupAuthNetworks(ctx context.Context, target *resolved.Instance, mgr *co
 			}
 			return err
 		}
+
+		mgr.Logger.Info("update of target instance applied")
 		return nil
 	})
 	if err != nil {

internal/pkg/migration/migration.go

@@ -74,6 +74,7 @@ func DeleteMigrationJob(ctx context.Context, migrationName string, gcpProject *r
 			}
 		}
 
+		mgr.Logger.Info("migration job deleted", "name", migrationName)
 		return nil
 	})
 	if err != nil {
@@ -182,6 +183,7 @@ func GetMigrationJob(ctx context.Context, migrationName string, gcpProject *reso
 			return nil, retry.RetryableError(fmt.Errorf("failed to get migration job: %w", err))
 		}
 
+		mgr.Logger.Info("got migration job", "name", migrationJob.Name)
 		return migrationJob, err
 	})