Skip to content

Commit c7282ff

Browse files
tronghnmortenlj
andcommitted
promote: return early if migration job already completed
Co-authored-by: Morten Lied Johansen <[email protected]>
1 parent bd889a7 commit c7282ff

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

internal/pkg/promote/promote.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ import (
44
"context"
55
"errors"
66
"fmt"
7-
"github.com/nais/cloudsql-migrator/internal/pkg/migration"
87
"time"
98

109
monitoring "cloud.google.com/go/monitoring/apiv3/v2"
1110
"cloud.google.com/go/monitoring/apiv3/v2/monitoringpb"
1211
"github.com/nais/cloudsql-migrator/internal/pkg/common_main"
1312
"github.com/nais/cloudsql-migrator/internal/pkg/instance"
13+
"github.com/nais/cloudsql-migrator/internal/pkg/migration"
1414
"github.com/nais/cloudsql-migrator/internal/pkg/resolved"
1515
"google.golang.org/api/datamigration/v1"
1616
"google.golang.org/api/iterator"
@@ -29,6 +29,11 @@ func CheckReadyForPromotion(ctx context.Context, source, target *resolved.Instan
2929
return err
3030
}
3131

32+
if migrationJob.State == "COMPLETED" {
33+
mgr.Logger.Info("migration job is already completed, continuing...", "migrationName", migrationName)
34+
return nil
35+
}
36+
3237
if migrationJob.State != "RUNNING" {
3338
return fmt.Errorf("migration job is not running: %s", migrationJob.State)
3439
}

0 commit comments

Comments
 (0)