Skip to content

Commit 8f9658e

Browse files
committed
Refactor Cost summary section to use SummaryCard component for improved readability and maintainability
1 parent 480d1b2 commit 8f9658e

File tree

1 file changed

+16
-53
lines changed

1 file changed

+16
-53
lines changed

src/routes/team/[team]/(teamPages)/bigquery/+page.svelte

+16-53
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,12 @@
55
import WorkloadLink from '$lib/components/WorkloadLink.svelte';
66
77
import Cost from '$lib/components/Cost.svelte';
8+
import SummaryCard from '$lib/components/SummaryCard.svelte';
89
import GraphErrors from '$lib/GraphErrors.svelte';
910
import CostIcon from '$lib/icons/CostIcon.svelte';
1011
import { resourceLink } from '$lib/utils/links';
1112
import { changeParams } from '$lib/utils/searchparams';
12-
import {
13-
Button,
14-
HelpText,
15-
Skeleton,
16-
Table,
17-
Tbody,
18-
Td,
19-
Th,
20-
Thead,
21-
Tr
22-
} from '@nais/ds-svelte-community';
13+
import { Button, Skeleton, Table, Tbody, Td, Th, Thead, Tr } from '@nais/ds-svelte-community';
2314
import { ChevronLeftIcon, ChevronRightIcon } from '@nais/ds-svelte-community/icons';
2415
import type { PageData } from './$houdini';
2516
@@ -60,22 +51,20 @@
6051
{@const datasets = $BigQuery.data.team.bigQueryDatasets}
6152
<div class="summary-grid">
6253
<Card columns={3}>
63-
<div class="summaryCard">
64-
<div class="summaryIcon" style="--bg-color: #91dc75">
65-
<CostIcon size="32" color="#91dc75" />
66-
</div>
67-
<div class="summary">
68-
<h4>
69-
Cost
70-
<HelpText title="">Total Big Query cost for team for the last 30 days.</HelpText>
71-
</h4>
72-
{#if cost !== PendingValue}
73-
<Cost cost={cost.daily.sum} />
74-
{:else}
75-
<Skeleton variant="text" />
76-
{/if}
77-
</div>
78-
</div>
54+
<SummaryCard
55+
title="Cost"
56+
helpText="Total Big Query cost for team for the last 30 days."
57+
color="green"
58+
>
59+
{#snippet icon({ color })}
60+
<CostIcon size="32" {color} />
61+
{/snippet}
62+
{#if cost !== PendingValue}
63+
<Cost cost={cost.daily.sum} />
64+
{:else}
65+
<Skeleton variant="text" />
66+
{/if}
67+
</SummaryCard>
7968
</Card>
8069
</div>
8170
<Card columns={12}>
@@ -184,30 +173,4 @@
184173
row-gap: 1rem;
185174
margin-bottom: 1rem;
186175
}
187-
.summaryCard {
188-
display: grid;
189-
grid-template-columns: 50px 1fr;
190-
align-items: center;
191-
gap: 20px;
192-
}
193-
.summaryIcon {
194-
display: flex;
195-
background-color: color-mix(in srgb, var(--bg-color) 10%, white);
196-
justify-content: center;
197-
align-items: center;
198-
width: 50px;
199-
height: 50px;
200-
border: 2px solid var(--bg-color);
201-
border-radius: 5px;
202-
}
203-
.summary {
204-
width: 100%;
205-
}
206-
.summary > h4 {
207-
display: flex;
208-
justify-content: space-between;
209-
margin: 0;
210-
font-size: 1rem;
211-
color: var(--color-text-secondary);
212-
}
213176
</style>

0 commit comments

Comments
 (0)