Skip to content

Commit 5069fa0

Browse files
committed
reduce log verbosity for SendDeviceConfiguration
1 parent a4030f3 commit 5069fa0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

cmd/apiserver/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,11 +252,11 @@ func run() error {
252252
for {
253253
device := <-updates
254254
session, err := sessions.CachedSessionFromDeviceID(device.Id)
255-
log.Infof("Pushing configuration for device %d, session key %s, error %s", device.Id, session.GetKey(), err)
255+
log.Debugf("Pushing configuration for device %d, error %s", device.Id, err)
256256
if err == nil {
257257
err = grpcHandler.SendDeviceConfiguration(context.TODO(), session.GetKey())
258258
}
259-
if err != nil {
259+
if err != nil && !errors.Is(err, api.ErrNoSession) {
260260
log.Error(err)
261261
}
262262
}

pkg/apiserver/api/grpcserver.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package api
22

33
import (
44
"context"
5+
"errors"
56
"fmt"
67
"sync"
78

@@ -25,6 +26,7 @@ type grpcServer struct {
2526
}
2627

2728
var _ pb.APIServerServer = &grpcServer{}
29+
var ErrNoSession = errors.New("no session")
2830

2931
func NewGRPCServer(db database.APIServer, authenticator auth.Authenticator) *grpcServer {
3032
return &grpcServer{
@@ -56,11 +58,9 @@ func (s *grpcServer) GetDeviceConfiguration(request *pb.GetDeviceConfigurationRe
5658
}
5759

5860
func (s *grpcServer) SendDeviceConfiguration(ctx context.Context, sessionKey string) error {
59-
log.Infof("SendDeviceConfiguration(%s)", sessionKey)
60-
6161
stream, ok := s.streams[sessionKey]
6262
if !ok {
63-
return fmt.Errorf("no session")
63+
return ErrNoSession
6464
}
6565

6666
sessionInfo, err := s.db.ReadSessionInfo(ctx, sessionKey)

0 commit comments

Comments
 (0)