handle sql query error

Author: sechmann

apiserver/api/api.go

@@ -27,6 +27,7 @@ func (a *api) gatewayConfig(w http.ResponseWriter, r *http.Request) {
 	clients, err := a.db.ReadClients()
 
 	if err != nil {
+		log.Errorf("reading clients from database: %v", err)
 		w.WriteHeader(http.StatusInternalServerError)
 		return
 	}

apiserver/database/database.go

@@ -52,7 +52,13 @@ func (d *database) ReadClients() (clients []Client, err error) {
 	rows, err := d.conn.Query(ctx, query)
 
 	if err != nil {
-		return nil, fmt.Errorf("querying for clients: %s", err)
+		return nil, fmt.Errorf("querying for clients: %v", err)
+	}
+
+	defer rows.Close()
+
+	if rows.Err() != nil {
+		return nil, fmt.Errorf("querying for clients: %v", rows.Err())
 	}
 
 	for rows.Next() {

go.mod

@@ -7,5 +7,5 @@ require (
 	github.com/jackc/pgx/v4 v4.5.0
 	github.com/lib/pq v1.3.0
 	github.com/sirupsen/logrus v1.4.2
-	github.com/spf13/pflag v1.0.5 // indirect
+	github.com/spf13/pflag v1.0.5
 )