Skip to content

Commit 00eded2

Browse files
committed
fix heading hierarchy
1 parent a069a93 commit 00eded2

File tree

4 files changed

+21
-23
lines changed

4 files changed

+21
-23
lines changed

src/lib/Header.svelte

+6-9
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@
77
</script>
88

99
<header class="header">
10-
<h1 class="heading">
11-
<a class="home" href="/">
12-
<Nais />
13-
<span class="name">Nais</span>
14-
</a>
15-
</h1>
10+
<a class="home" href="/">
11+
<Nais />
12+
<span class="name">Nais</span>
13+
</a>
1614
<button class="main-menu-toggle" class:isOpen onclick={() => (isOpen = !isOpen)}>
1715
<svg
1816
class="open-icon"
@@ -105,9 +103,6 @@
105103
color-mix(in srgb, var(--color-spectrum-5) 14.5%, transparent)
106104
);
107105
}
108-
.heading {
109-
margin: 0;
110-
}
111106
.home {
112107
text-decoration: none;
113108
transition: color 50ms;
@@ -116,10 +111,12 @@
116111
grid-template-columns: auto 1fr;
117112
gap: 4px;
118113
align-items: baseline;
114+
font-size: 2rem;
119115
}
120116
.name {
121117
font-size: 2.3rem;
122118
color: var(--color-black);
119+
font-weight: bold;
123120
}
124121
.main-menu-toggle {
125122
grid-area: button;

src/lib/Hero.svelte

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33

44
<div class="hero">
55
<div class="content">
6-
<h2 class="heading">
6+
<h1 class="heading">
77
En plattform laget av Nav for å gi fart og flyt til utviklerne av det offentlige Norge
8-
</h2>
8+
</h1>
99
<p class="text">
1010
Vi mener at det skal være lett å gjøre rett. Utviklere bør kunne fokusere på det som betyr noe
1111
- å lage gode applikasjoner.
@@ -35,6 +35,7 @@
3535
max-width: 55ch;
3636
}
3737
.heading {
38+
font-size: 1.5em;
3839
margin: 0;
3940
}
4041
.cloud {

src/routes/(pages)/blog/+page.svelte

+9-9
Original file line numberDiff line numberDiff line change
@@ -6,32 +6,32 @@
66
let { data }: { data: PageData } = $props();
77
</script>
88

9-
<ul class="list">
9+
<div class="articles">
1010
{#each data.posts as post}
11-
<li class="item" lang={post.metadata.language}>
12-
<h2 class="heading">
11+
<article lang={post.metadata.language}>
12+
<h1 class="heading">
1313
<a class="link" href={`/blog/posts/${post.slug}`}>
1414
{post.metadata.title}
1515
</a>
16-
</h2>
16+
</h1>
1717
<div class="byline">
1818
{post.metadata.language === "en"
1919
? `${format(post.metadata.date, "MMMM d, yyyy")} by ${post.metadata.author}`
2020
: `${format(post.metadata.date, "d. MMMM yyyy", { locale: nb })} av ${post.metadata.author}`}
2121
</div>
2222
<div class="description">{post.metadata.description}</div>
23-
</li>
23+
</article>
2424
{/each}
25-
</ul>
25+
</div>
2626

2727
<style>
2828
.byline {
2929
font-style: italic;
3030
font-size: 1rem;
3131
}
32-
.list {
32+
.articles {
3333
margin: 0;
34-
margin-top: 1.34em;
34+
margin-top: 3em;
3535
list-style: none;
3636
margin-inline: auto;
3737
display: flex;
@@ -49,7 +49,7 @@
4949
.link:hover {
5050
text-decoration: none;
5151
}
52-
.item {
52+
article {
5353
display: flex;
5454
flex-direction: column;
5555
align-items: start;

src/routes/(pages)/log/+page.svelte

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
{#if i > 0}
1313
<hr />
1414
{/if}
15-
<div lang={metadata.language}>
16-
<h2 class="heading" id={slug}><a class="anchorLink" href="#{slug}">{metadata.title}</a></h2>
15+
<article lang={metadata.language}>
16+
<h1 class="heading" id={slug}><a class="anchorLink" href="#{slug}">{metadata.title}</a></h1>
1717
<div class="byline">
1818
{metadata.language === "en"
1919
? `${format(metadata.date, "MMMM d, yyyy")} by ${metadata.author}`
@@ -22,7 +22,7 @@
2222
<div class="post">
2323
<Post />
2424
</div>
25-
</div>
25+
</article>
2626
{/each}
2727

2828
<style>

0 commit comments

Comments
 (0)