Identify and fix deprecations

Author: christeredvartsen

Diff for: composer.json

@@ -43,7 +43,11 @@
   },
   "require-dev": {
     "navikt/coding-standard": "^2.0",
+    "phpstan/extension-installer": "^1.4",
     "phpstan/phpstan": "^2.1",
+    "phpstan/phpstan-deprecation-rules": "^2.0",
+    "phpstan/phpstan-doctrine": "^2.0",
+    "phpstan/phpstan-phpunit": "^2.0",
     "phpunit/phpunit": "^11.5",
     "symfony/var-dumper": "^7.2"
   },
@@ -63,6 +67,9 @@
     ]
   },
   "config": {
-    "sort-packages": true
+    "sort-packages": true,
+    "allow-plugins": {
+      "phpstan/extension-installer": true
+    }
   }
 }

Diff for: composer.lock

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="vendor/autoload.php" beStrictAboutOutputDuringTests="true" requireCoverageMetadata="true" beStrictAboutCoverageMetadata="false">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="vendor/autoload.php" beStrictAboutOutputDuringTests="true" requireCoverageMetadata="true" displayDetailsOnPhpunitDeprecations="true">
   <testsuites>
     <testsuite name="default">
       <directory suffix="Test.php">tests</directory>

Diff for: phpunit.dist.xml

@@ -3,20 +3,15 @@
 namespace Naisdevice\Jita\Controllers;
 
 use Doctrine\DBAL\Connection;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ResponseInterface as Response;
 use Psr\Http\Message\ServerRequestInterface as Request;
 use Psr\Http\Message\StreamInterface;
 
-/**
- * @coversDefaultClass Naisdevice\Jita\Controllers\ApiController
- */
+#[CoversClass(ApiController::class)]
 class ApiControllerTest extends TestCase
 {
-    /**
-     * @covers ::__construct
-     * @covers ::requests
-     */
     public function testWillRenderRequests(): void
     {
         $connection = $this->createConfiguredMock(Connection::class, [
@@ -65,10 +60,6 @@ public function testWillRenderRequests(): void
         $this->assertSame($modifiedResponse, $controller->requests($request, $response));
     }
 
-    /**
-     * @covers ::gatewayAccess
-     * @covers ::getAccessRowsWithTtl
-     */
     public function testCanGetGatewayAccess(): void
     {
         $connection = $this->createConfiguredMock(Connection::class, [
@@ -130,10 +121,6 @@ public function testCanGetGatewayAccess(): void
         );
     }
 
-    /**
-     * @covers ::gatewaysAccess
-     * @covers ::getAccessRowsWithTtl
-     */
     public function testCanGetGatewaysAccess(): void
     {
         $connection = $this->createConfiguredMock(Connection::class, [
@@ -197,10 +184,6 @@ public function testCanGetGatewaysAccess(): void
         );
     }
 
-    /**
-     * @covers ::userAccess
-     * @covers ::getAccessRowsWithTtl
-     */
     public function testCanGetUserAccess(): void
     {
         $connection = $this->createConfiguredMock(Connection::class, [