Populate the .status.problems field with critical errors

This patch duplicates the information from `.status.conditions` into the
new `.status.problems` field.

Co-authored-by: Frode Sundby <[email protected]>
Co-authored-by: Johnny Horvi <[email protected]>

Author: 3 people

Diff for: go.mod

@@ -13,7 +13,7 @@ require (
 	github.com/magiconair/properties v1.8.9
 	github.com/mitchellh/hashstructure v1.1.0
 	github.com/mitchellh/mapstructure v1.5.0
-	github.com/nais/liberator v0.0.0-20250120121331-1a7304c71267
+	github.com/nais/liberator v0.0.0-20250127133505-12f7ef36a778
 	github.com/novln/docker-parser v1.0.0
 	github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.74.0
 	github.com/prometheus/client_golang v1.20.5

Diff for: go.sum

@@ -123,8 +123,8 @@ github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9G
 github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
-github.com/nais/liberator v0.0.0-20250120121331-1a7304c71267 h1:Ngg/i5VCv0yinrrlOef9ualH6Xml0Ga3DcxlfESUHFU=
-github.com/nais/liberator v0.0.0-20250120121331-1a7304c71267/go.mod h1:DtQgc26XvoZFe8jy0++wbuFUu5yCFTQ3vGV+y7TA7Uw=
+github.com/nais/liberator v0.0.0-20250127133505-12f7ef36a778 h1:MWdNTpbe4mXTWZhfRzA7w6mX7AB53+L8Fy879ZJNzpg=
+github.com/nais/liberator v0.0.0-20250127133505-12f7ef36a778/go.mod h1:PwYxh3ZMUsk4YluGK+XbamXcMCQUpCBM/DUSQdU/Th0=
 github.com/novln/docker-parser v1.0.0 h1:PjEBd9QnKixcWczNGyEdfUrP6GR0YUilAqG7Wksg3uc=
 github.com/novln/docker-parser v1.0.0/go.mod h1:oCeM32fsoUwkwByB5wVjsrsVQySzPWkl3JdlTn1txpE=
 github.com/nxadm/tail v1.4.8 h1:nPr65rt6Y5JFSKQO7qToXr7pePgD6Gwiw05lkbyAQTE=

Diff for: pkg/synchronizer/synchronizer.go

@@ -152,6 +152,9 @@ func (n *Synchronizer) Reconcile(ctx context.Context, req ctrl.Request, app reso
 	// fixme: can be removed when we don't have garbage data anymore. Late 2024?
 	app.GetStatus().Conditions = nil
 
+	// Clear out any old problems from previous synchronizations.
+	app.GetStatus().ClearProblems()
+
 	kind := app.GetObjectKind().GroupVersionKind().Kind
 	changed := true
 
@@ -224,6 +227,7 @@ func (n *Synchronizer) Reconcile(ctx context.Context, req ctrl.Request, app reso
 	rollout, err := n.Prepare(ctx, app)
 	if err != nil {
 		app.GetStatus().SetSynchronizationStateWithCondition(events.FailedPrepare, err.Error())
+		app.GetStatus().SetError(err.Error())
 		n.reportError(ctx, app.GetStatus().SynchronizationState, err, app)
 		return ctrl.Result{RequeueAfter: prepareRetryInterval}, nil
 	}
@@ -247,6 +251,7 @@ func (n *Synchronizer) Reconcile(ctx context.Context, req ctrl.Request, app reso
 	rollout.ResourceOperations, err = n.generator.Generate(rollout.Source, rollout.Options)
 	if err != nil {
 		app.GetStatus().SetSynchronizationStateWithCondition(events.FailedGenerate, err.Error())
+		app.GetStatus().SetError(err.Error())
 		n.reportError(ctx, app.GetStatus().SynchronizationState, err, app)
 		return ctrl.Result{}, err
 	}
@@ -260,9 +265,11 @@ func (n *Synchronizer) Reconcile(ctx context.Context, req ctrl.Request, app reso
 	if err != nil {
 		if retry {
 			app.GetStatus().SetSynchronizationStateWithCondition(events.Retrying, err.Error())
+			// No error in problems array, because this is a transient error which the user has no control over.
 			n.reportError(ctx, app.GetStatus().SynchronizationState, err, app)
 		} else {
 			app.GetStatus().SetSynchronizationStateWithCondition(events.FailedSynchronization, err.Error())
+			app.GetStatus().SetError(err.Error())
 			app.GetStatus().SynchronizationHash = rollout.SynchronizationHash // permanent failure
 			n.reportError(ctx, app.GetStatus().SynchronizationState, err, app)
 			err = nil