Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional IAM roles for Google service accounts #532

Closed
tronghn opened this issue May 29, 2024 · 5 comments
Closed

Additional IAM roles for Google service accounts #532

tronghn opened this issue May 29, 2024 · 5 comments

Comments

@tronghn
Copy link
Contributor

tronghn commented May 29, 2024

Some applications use GCP products that require additional roles that grants their Google service account (their identity) access to itself (as a resource), e.g. roles/iam.serviceAccountTokenCreator.

naiserator creates an IAMPolicy that sets up bindings for workload identity.
This IAM policy is thus authoriative for the service account. External modifications are overridden by Config Connector.

A possible solution would be to allow applications to opt in for such additional roles and have naiserator assign these via the IAMPolicy resource.

See also https://nav-it.slack.com/archives/C050DP53VPH/p1716977528649729

@kimtore
Copy link
Contributor

kimtore commented Oct 22, 2024

Did anyone else bump into this issue?

@tronghn
Copy link
Contributor Author

tronghn commented Oct 23, 2024

Not as far as I've seen. I think #380 would allow the teams to control this themselves, so we could close this as not planned in favor of that issue.

@kimtore
Copy link
Contributor

kimtore commented Oct 23, 2024

Would that mean that users will mutate the IAMServiceAccount family of resources that were created by Naiserator?

@tronghn
Copy link
Contributor Author

tronghn commented Oct 23, 2024

No, ideally they'd only make additive changes. I think that requires us to move away from IAMPolicy to IAMPolicyMember instead.

But there's currently no way for them to do this while these resources are managed in another namespace.

@kimtore
Copy link
Contributor

kimtore commented Oct 23, 2024

OK, closing this as not planned then, in favor of #380.

@kimtore kimtore closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants