Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default settings for StorageBuckets #590

Open
jhrv opened this issue Feb 7, 2025 · 0 comments
Open

Change default settings for StorageBuckets #590

jhrv opened this issue Feb 7, 2025 · 0 comments

Comments

@jhrv
Copy link
Contributor

jhrv commented Feb 7, 2025

uniform bucket level access

uniformBucketLevelAccess: true is the default from Google, and new organizations even come with a constraint. This should be the default, and does not need to be exposed to the end user.

This will require that we change the way we grant the application service account access to the bucket. Today we create a StorageBucketAccessControl resource where we grant the user OWNER on the bucket. This we can drop, and just grant the SA roles/storage.objectUser instead.

This cleans up the logic in pkg/resourcecreator/google/storagebucket/storagebucket.go

disable soft-delete

Soft-delete is a new setting that come as default. This is not needed, and can be disabled.

softDeletePolicy:
    retentionDurationSeconds: 0 # 604800 is default (1 week)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant