From 331a13da7c213adfe9f7483e26d7f512acbb9b78 Mon Sep 17 00:00:00 2001
From: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Date: Mon, 25 Jan 2021 17:21:59 +1300
Subject: [PATCH] [docs]: scrypt use correct units and fix interactive login
 usage

The sample **interactive login** example has parameters for 16 MiB but incorrectly describes RAM used as 2 MB.

MB/GB units of memory are used, but the correct representation is MiB (MebiBytes) and GiB (GibiBytes). This may be an issue on other pages as well.
---
 mac-and-key-derivation/scrypt.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mac-and-key-derivation/scrypt.md b/mac-and-key-derivation/scrypt.md
index 363fa59..4506b07 100644
--- a/mac-and-key-derivation/scrypt.md
+++ b/mac-and-key-derivation/scrypt.md
@@ -25,13 +25,13 @@ The **memory** in Scrypt is accessed in strongly **dependent order** at each ste
 Memory required = 128 * N * r * p bytes
 ```
 
-Example: e.g. 128 \* N \* r \* p = 128 \* 16384 \* 8 \* 1 = 16 MB  
-\(or 128 \* N \* r \* p = 128 \* 2048 \* 8 \* 1 = 2 MB\)
+Example: e.g. 128 \* N \* r \* p = 128 \* 16384 \* 8 \* 1 = 16 MiB  
+\(or 128 \* N \* r \* p = 128 \* 2048 \* 8 \* 1 = 2 MiB\)
 
 **Choosing parameters** depends on how much you want to wait and what level of security \(password cracking resistance\) do you want to achieve:
 
-* Sample parameters for **interactive login**: N=16384, r=8, p=1 \(RAM = 2 MB\). For interactive login you most probably do not want to wait more than a 0.5 seconds, so the computations should be very slow. Also at the server side, it is usual that many users can login in the same time, so slow Scrypt computation will slow down the entire system.
-* Sample parameters for **file encryption**: N=1048576, r=8, p=1 \(RAM = 1 GB\). When you encrypt your hard drive, you will unlock the encrypted data in rare cases, usually not more than 2-3 times per day, so you may want to wait for 2-3 seconds to increase the security.
+* Sample parameters for **interactive login**: N=16384, r=8, p=1 \(RAM = 16 MiB\). For interactive login you most probably do not want to wait more than a 0.5 seconds, so the computations should be very slow. Also at the server side, it is usual that many users can login in the same time, so slow Scrypt computation will slow down the entire system.
+* Sample parameters for **file encryption**: N=1048576, r=8, p=1 \(RAM = 1 GiB\). When you encrypt your hard drive, you will unlock the encrypted data in rare cases, usually not more than 2-3 times per day, so you may want to wait for 2-3 seconds to increase the security.
 
 You can perform tests and choose the Scrypt parameters yourself during the design and development of your app or system. Always try to use the **fastest possible implementation of Scrypt** for your language and platform, because crackers will definitely use it. Some implementations \(e.g. in Python\) may be 100 times slower than the fastest ones!