Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical fix - Reduce Object question #140

Open
jafarlow opened this issue Oct 25, 2019 · 1 comment · May be fixed by #152
Open

Grammatical fix - Reduce Object question #140

jafarlow opened this issue Oct 25, 2019 · 1 comment · May be fixed by #152

Comments

@jafarlow
Copy link

Describe the bug
In the second bullet point of the explanation, there are three updates which will facilitate reading.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://quiz.typeofnan.dev/reduce-object/
  2. Click on any wrong answer to generate the explanation.
  3. Scroll down to the explanations, bullet point 2.
  4. See error

Expected behavior
There is a grammatical error with a missing period between two sentences. There should be one between "element" and "In".

You've established that any reference to pieces of the code are displayed in code block syntax (I think that's how to describe it). In this bullet point, "agg" and "el" should be displayed as such.

Screenshots

Screenshot from 2019-10-25 13-01-59

Desktop (please complete the following information):

  • OS: Ubuntu 18.04.3 LTS
  • Browser: Chrome
  • Version: 77.0.3865.120
@stevesioli
Copy link

I can fix this

stevesioli added a commit to stevesioli/typeofnan-javascript-quizzes that referenced this issue Nov 1, 2019
In the second bullet point, add period between sentences

Closes nas5w#140
@stevesioli stevesioli linked a pull request Nov 1, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants