Skip to content

Backported fix for migration bug where OnboardingTask was not filtered correctly #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2025
Merged

Backported fix for migration bug where OnboardingTask was not filtered correctly #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ec109e
Backporting PR-#455
Defiantearth Nov 20, 2025
b6dafaa
Changing nautobot version to 2.4 in ci
Defiantearth Nov 20, 2025
4647d0b
Apply suggestion from @gsnider2195
gsnider2195 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,14 @@ jobs:
matrix:
python-version: ["3.10"] # 3.12 stable is tested in unittest_report stage.
db-backend: ["postgresql"]
nautobot-version: ["stable"]
nautobot-version: ["2.4"]
include:
- python-version: "3.11"
db-backend: "postgresql"
nautobot-version: "2.4.20"
- python-version: "3.12"
db-backend: "mysql"
nautobot-version: "stable"
nautobot-version: "2.4"
runs-on: "ubuntu-latest"
env:
INVOKE_NAUTOBOT_DEVICE_ONBOARDING_PYTHON_VER: "${{ matrix.python-version }}"
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:
matrix:
python-version: ["3.12"]
db-backend: ["postgresql"]
nautobot-version: ["stable"]
nautobot-version: ["2.4"]
runs-on: "ubuntu-latest"
permissions:
pull-requests: "write"
Expand Down
1 change: 1 addition & 0 deletions changes/458.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed migration bug where OnboardingTask was not filtered correctly.
2 changes: 1 addition & 1 deletion nautobot_device_onboarding/migrations/0005_migrate_site_to_location_part_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ def migrate_to_location(apps, schema_editor):
OnboardingTask = apps.get_model("nautobot_device_onboarding", "OnboardingTask")
location_model = apps.get_model("dcim", "Location")

for task_object in OnboardingTask.objects.all():
for task_object in OnboardingTask.objects.filter(site__isnull=False):
# get the new Location object from the site and set it
task_object.location = location_model.objects.get(name=task_object.site.name)
task_object.save()
Expand Down