[List] Deprecate listprops title, headingTag and description (#3537)

* 🔥 Deprecated title, headingTag and description for List

* 📝 changeset

Author: KenAJoh

.changeset/lemon-falcons-retire.md

@@ -0,0 +1,5 @@
+---
+"@navikt/ds-react": minor
+---
+
+List: Marked `title`, `headingTag` and `description` properties as deprecated. These will not be supported in future versions and should be migrated from when possible.

@navikt/core/css/darkside/list.darkside.css

@@ -1,12 +1,7 @@
 .navds-list ul,
 .navds-list ol {
   padding: 0;
-  margin-block: var(--ax-space-16);
-}
-
-.navds-list--small ul,
-.navds-list--small ol {
-  margin-block: var(--ax-space-12);
+  margin: 0;
 }
 
 .navds-list {

@navikt/core/react/src/list/ListItem.tsx @navikt/core/react/src/list/List.Item.tsx

@@ -1,8 +1,8 @@
 import cl from "clsx";
 import React, { forwardRef, useContext } from "react";
 import { BodyLong } from "../typography";
-import { ListContext } from "./context";
-import type { ListItemProps } from "./types";
+import { ListContext } from "./List.context";
+import type { ListItemProps } from "./List.types";
 
 /**
  * @see 🏷️ {@link ListItemProps}

@navikt/core/react/src/list/context.ts @navikt/core/react/src/list/List.context.ts

@@ -1,5 +1,5 @@
 import { createContext } from "react";
-import { ListProps } from "./types";
+import { ListProps } from "./List.types";
 
 interface ListContextProps {
   listType: Exclude<ListProps["as"], undefined>;

@navikt/core/react/src/list/List.tsx

@@ -1,10 +1,11 @@
 import cl from "clsx";
 import React, { forwardRef, useContext } from "react";
+import { useThemeInternal } from "../theme/Theme";
 import { BodyLong, BodyShort, Heading, HeadingProps } from "../typography";
-import { ListItem } from "./ListItem";
-import { ListContext } from "./context";
+import { ListItem } from "./List.Item";
+import { ListContext } from "./List.context";
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
-import type { ListItemProps, ListProps } from "./types";
+import type { ListItemProps, ListProps } from "./List.types";
 
 const headingSizeMap: Record<
   Exclude<ListProps["size"], undefined>,
@@ -56,7 +57,40 @@ export const List = forwardRef<HTMLDivElement, ListProps>(
   ) => {
     const { size: contextSize } = useContext(ListContext);
 
+    const themeContext = useThemeInternal(false);
+
     const listSize = size ?? contextSize;
+
+    if (themeContext) {
+      if (
+        process.env.NODE_ENV !== "production" &&
+        (title || description || headingTag)
+      ) {
+        console.warn(
+          "List: title, description and headingTag are deprecated and will not work with updated theme for Aksel.",
+        );
+      }
+
+      return (
+        <ListContext.Provider
+          value={{
+            listType: ListTag,
+            size: listSize,
+          }}
+        >
+          <BodyLong
+            as="div"
+            {...rest}
+            size={listSize}
+            ref={ref}
+            className={cl("navds-list", `navds-list--${listSize}`, className)}
+          >
+            <ListTag role="list">{children}</ListTag>
+          </BodyLong>
+        </ListContext.Provider>
+      );
+    }
+
     return (
       <ListContext.Provider
         value={{

@navikt/core/react/src/list/types.ts @navikt/core/react/src/list/List.types.ts

@@ -7,15 +7,18 @@ export interface ListProps extends React.HTMLAttributes<HTMLDivElement> {
   as?: "ul" | "ol";
   /**
    * List heading title.
+   * @deprecated Prop will be removed in future versions.
    */
   title?: string;
   /**
    * List heading description.
+   * @deprecated Prop will be removed in future versions.
    */
   description?: string;
   /**
    * Allows setting a different HTML h-tag.
    * @default "h3"
+   * @deprecated Prop will be removed in future versions.
    */
   headingTag?: React.ElementType<any>;
   /**

@navikt/core/react/src/list/index.ts

@@ -1,4 +1,4 @@
 "use client";
 export { default as List } from "./List";
-export type { ListProps, ListItemProps } from "./types";
-export { default as ListItem } from "./ListItem";
+export type { ListProps, ListItemProps } from "./List.types";
+export { default as ListItem } from "./List.Item";