Fiks noen eslint errors

Author: LudvigHz

eslint.config.js

@@ -7,16 +7,28 @@ export default tseslint.config(
   prettier,
   ...tseslint.configs.recommendedTypeChecked,
   {
-    ignores: ['**/dist/**/*',],
+    ignores: ['**/dist/**/*'],
     languageOptions: {
       parserOptions: {
         project: ['./tsconfig.json', './packages/*/tsconfig.json'],
         tsconfigRootDir: import.meta.dirname,
       },
     },
+    rules: {
+      '@typescript-eslint/no-floating-promises': 'warn',
+      '@typescript-eslint/no-misused-promises': [
+        'error',
+        {
+          checksVoidReturn: false,
+        },
+      ],
+    },
+  },
+  {
+    files: ['**/*.js', 'vitest.workspace.ts'],
+    extends: [tseslint.configs.disableTypeChecked],
   },
   {
-    files: ['**/*.js','vitest.workspace.ts'],
-    extends: [tseslint.configs.disableTypeChecked]
-  }
+    ignores: ['**/postcss.config.cjs'],
+  },
 );

packages/dev-server/CustomServer.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { Serve, Server } from 'bun';
 import {
   Route,
@@ -248,9 +247,9 @@ export class CustomServer {
   };
 }
 
-const hasParam = <T extends Record<string, any>>(
+const hasParam = <T extends Record<string, string>>(
   key: string,
   params: T,
-): params is T & { [K in typeof key]: any } => {
+): params is T & { [K in typeof key]: string } => {
   return key in params && params[key] !== '';
 };

packages/dev-server/index.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { CustomServer } from './CustomServer';
 import { BadRequestResponse } from './responses/BadRequestResponse';
 import { InternalServerErrorResponse } from './responses/InternalServerErrorResponse';
@@ -8,6 +7,10 @@ import { NotFoundResponse } from './responses/NotFoundResponse';
 import { BunServerWebsocket } from './types';
 
 type Metadata = { ident: string };
+type Veileder = {
+  enheter: { enhetId: string }[];
+};
+type Event = { eventType: 'NY_AKTIV_ENHET' | 'NY_AKTIV_BRUKER'; verdi: string };
 
 const serve = () => {
   type Context = {
@@ -52,7 +55,7 @@ const serve = () => {
       return new BadRequestResponse('Missing enhetId');
     }
 
-    const response = mockMe.enheter.find(
+    const response = (mockMe as Veileder).enheter.find(
       (enhet) => enhet.enhetId === request.params.enhetId,
     );
 
@@ -68,11 +71,9 @@ const serve = () => {
       return new BadRequestResponse('No body provided');
     }
 
-    const {
-      eventType,
-      verdi,
-    }: { eventType: 'NY_AKTIV_ENHET' | 'NY_AKTIV_BRUKER'; verdi: string } =
-      await Bun.readableStreamToJSON(request.body);
+    const { eventType, verdi } = (await Bun.readableStreamToJSON(
+      request.body,
+    )) as Event;
 
     if (eventType === 'NY_AKTIV_BRUKER') {
       context.aktivBruker = verdi;
@@ -94,9 +95,9 @@ const serve = () => {
       return new BadRequestResponse('No body provided');
     }
 
-    const { code }: { code: string } = await Bun.readableStreamToJSON(
-      request.body,
-    );
+    const { code } = (await Bun.readableStreamToJSON(request.body)) as {
+      code: string;
+    };
 
     const fnr = codeToFnr[code];
 
@@ -112,9 +113,9 @@ const serve = () => {
       return new BadRequestResponse('No body provided');
     }
 
-    const { fnr }: { fnr: string } = await Bun.readableStreamToJSON(
-      request.body,
-    );
+    const { fnr } = (await Bun.readableStreamToJSON(request.body)) as {
+      fnr: string;
+    };
 
     const code = crypto.randomUUID();
 

packages/dev-server/types.ts

@@ -37,7 +37,7 @@ export interface WebSocketRoute<T = any> extends BaseRoute {
   };
 }
 
-export type Params = Record<string, any>;
+export type Params = Record<string, string>;
 export type BunServerMetadata = BaseRoute & {
   metadata?: Record<string, any> | undefined;
 };

packages/internarbeidsflate-decorator-v3/src/__mocks__/mock-handlers.ts

@@ -17,8 +17,7 @@ export const mockMe: Veileder = {
   ],
 };
 
-const getUrl = (path: string) =>
-  `${urlPrefix}/modiacontextholder/api${path}`;
+const getUrl = (path: string) => `${urlPrefix}/modiacontextholder/api${path}`;
 
 const getErrorResponse = (status = 500) => {
   return new HttpResponse(null, { status });
@@ -40,12 +39,11 @@ let context: Context = { aktivEnhet: '0118', aktivBruker: '10108000398' };
 
 export const updateMockContext = (newContext: Partial<Context>) => {
   context = {
-  ...context,
-  ...newContext,
-  }
+    ...context,
+    ...newContext,
+  };
 };
 
-
 export const getHandlers = (
   ws: WS,
   errorConfig: FailureConfig,

packages/internarbeidsflate-decorator-v3/src/store/EnhetValueManager.ts

@@ -40,7 +40,7 @@ export class EnhetValueManager extends ContextValueManager {
 
     const enheter = veileder.enheter;
     if (!enheter?.length) {
-      this.#resetFnrAndEnhetDueToNoLegalEnhet();
+      await this.#resetFnrAndEnhetDueToNoLegalEnhet();
       return;
     }
 
@@ -160,7 +160,7 @@ export class EnhetValueManager extends ContextValueManager {
   };
 
   readonly changeEnhetExternallyToLocalValue = async () => {
-    this.contextHolderApi.changeEnhet(this.state.enhet.value);
+    await this.contextHolderApi.changeEnhet(this.state.enhet.value);
     this.clearWSRequestedValue('enhet');
     this.closeModal('enhet');
   };

packages/internarbeidsflate-decorator-v3/src/wrapper/Wrapper.tsx

@@ -29,7 +29,7 @@ const Wrapper: React.FC = () => {
         {
           onOpen: () => setWsConntected(true),
           onClose: () => setWsConntected(false),
-          onMessage: (event) => {
+          onMessage: (event: MessageEvent<string>) => {
             setWsMessages((messages) => {
               return [...messages, event.data];
             });
@@ -46,7 +46,7 @@ const Wrapper: React.FC = () => {
     await api.changeEnhet(wsEnhet);
   };
 
-  const sendNewFnr = async () => {
+  const sendNewFnr = () => {
     await api.changeFnr(wsFnr);
   };