feat: add timeout to MockOAuth2Server.takeRequest()

* avoid waiting for request indefinitely

Author: tommytroen

src/main/kotlin/no/nav/security/mock/oauth2/MockOAuth2Server.kt

@@ -32,6 +32,8 @@ import no.nav.security.mock.oauth2.token.OAuth2TokenCallback
 import okhttp3.HttpUrl
 import okhttp3.mockwebserver.MockResponse
 import okhttp3.mockwebserver.RecordedRequest
+import java.lang.RuntimeException
+import java.util.concurrent.TimeUnit
 
 private val log = KotlinLogging.logger { }
 
@@ -75,9 +77,11 @@ open class MockOAuth2Server(
 
     fun enqueueCallback(oAuth2TokenCallback: OAuth2TokenCallback) = defaultRequestHandler.enqueueTokenCallback(oAuth2TokenCallback)
 
-    fun takeRequest(): RecordedRequest =
-        (httpServer as? MockWebServerWrapper)?.mockWebServer?.takeRequest()
-            ?: throw UnsupportedOperationException("can only takeRequest when httpServer is of type MockWebServer")
+    @JvmOverloads
+    fun takeRequest(timeout: Long = 2, unit: TimeUnit = TimeUnit.SECONDS): RecordedRequest =
+        (httpServer as? MockWebServerWrapper)?.mockWebServer?.let {
+            it.takeRequest(timeout, unit) ?: throw RuntimeException("no request found in queue within timeout $timeout $unit")
+        } ?: throw UnsupportedOperationException("can only takeRequest when httpServer is of type MockWebServer")
 
     fun wellKnownUrl(issuerId: String): HttpUrl = url(issuerId).toWellKnownUrl()
     fun tokenEndpointUrl(issuerId: String): HttpUrl = url(issuerId).toTokenEndpointUrl()

src/test/kotlin/no/nav/security/mock/oauth2/MockOAuth2ServerTest.kt

@@ -7,6 +7,7 @@ import com.nimbusds.jwt.JWTClaimsSet
 import com.nimbusds.jwt.SignedJWT
 import com.nimbusds.oauth2.sdk.GrantType
 import com.nimbusds.oauth2.sdk.id.Issuer
+import io.kotest.assertions.throwables.shouldThrow
 import io.kotest.matchers.maps.shouldContainAll
 import io.kotest.matchers.shouldBe
 import io.kotest.matchers.string.shouldStartWith
@@ -37,6 +38,7 @@ import org.junit.jupiter.api.AfterEach
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
+import java.util.concurrent.TimeUnit
 
 // TODO add more tests for exception handling
 class MockOAuth2ServerTest {
@@ -414,6 +416,16 @@ class MockOAuth2ServerTest {
         )
     }
 
+    @Test
+    fun `takeRequest should time out if no request is received`(){
+        shouldThrow<java.lang.RuntimeException> {
+            server.takeRequest(5, TimeUnit.MILLISECONDS)
+        }
+        val url = server.wellKnownUrl("1")
+        client.get(url)
+        server.takeRequest().requestUrl shouldBe url
+    }
+
     private fun retrieveJwks(jwksUri: String): JWKSet {
         return client.newCall(
             Request.Builder()