Skip to content

Commit f4053ea

Browse files
authored
Opprydding Amplitude for Filtervalg og Accordion (#1989)
* Setter komponent 'alternativ-målgruppe' og 'skjemaoversikt-filter' * Logging av Accordion var invertert * Konsistent taxonomy for filtervalg
1 parent ef2a706 commit f4053ea

File tree

7 files changed

+17
-8
lines changed

7 files changed

+17
-8
lines changed

src/components/_common/accordion/Accordion.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ export const Accordion = ({ accordion }: AccordionProps) => {
2626

2727
useShortcuts({ shortcut: Shortcuts.SEARCH, callback: expandAll });
2828

29-
const openChangeHandler = (isOpen: boolean, title: string, index: number) => {
30-
if (isOpen) {
29+
const openChangeHandler = (isOpening: boolean, title: string, index: number) => {
30+
if (isOpening) {
3131
setOpenAccordions([...openAccordions, index]);
3232
} else {
3333
setOpenAccordions(openAccordions.filter((i) => i !== index));
3434
}
35-
logAmplitudeEvent(isOpen ? AnalyticsEvents.ACC_COLLAPSE : AnalyticsEvents.ACC_EXPAND, {
35+
logAmplitudeEvent(isOpening ? AnalyticsEvents.ACC_EXPAND : AnalyticsEvents.ACC_COLLAPSE, {
3636
tittel: title,
3737
opprinnelse: 'trekkspill',
3838
});

src/components/_common/filter-bar/FilterBar.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export const FilterBar = ({ layoutProps }: Props) => {
9090
kategori: filter.categoryName,
9191
filternavn: filter.filterName,
9292
opprinnelse: 'innholdtekst',
93+
komponent: 'FilterBar',
9394
});
9495
saveScrollPosition();
9596
toggleFilter(filter.id);

src/components/_common/overview-filters/OverviewFilters.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { useEffect, useRef, useState } from 'react';
22
import { FunnelIcon } from '@navikt/aksel-icons';
3-
import { Heading, Button } from '@navikt/ds-react';
3+
import { Button, Heading } from '@navikt/ds-react';
44
import { OverviewAreaFilter } from 'components/_common/overview-filters/area-filter/OverviewAreaFilter';
55
import { OverviewTaxonomyFilter } from 'components/_common/overview-filters/taxonomy-filter/OverviewTaxonomyFilter';
66
import { OverviewTextFilter } from 'components/_common/overview-filters/text-filter/OverviewTextFilter';
@@ -50,7 +50,9 @@ const MobileView = ({
5050
e.preventDefault();
5151
setIsOpen(!isOpen);
5252
logAmplitudeEvent(AnalyticsEvents.FILTER, {
53+
kategori: 'mobile-toggle',
5354
opprinnelse: 'oversiktsside filter mobil',
55+
komponent: 'MobileView',
5456
});
5557
}}
5658
className={style.mobileFilterButton}

src/components/_common/overview-filters/area-filter/OverviewAreaFilter.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ export const OverviewAreaFilter = ({ items }: Props) => {
2626

2727
const handleFilterUpdate = (area: Area) => {
2828
logAmplitudeEvent(AnalyticsEvents.FILTER, {
29-
omrade: area,
29+
kategori: 'område',
30+
filternavn: area,
3031
opprinnelse: 'oversiktsside områder',
32+
komponent: 'OverviewAreaFilter',
3133
});
3234
setAreaFilter(area);
3335
};

src/components/_common/overview-filters/taxonomy-filter/OverviewTaxonomyFilter.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ export const OverviewTaxonomyFilter = ({ items }: Props) => {
2525

2626
const handleFilterUpdate = (taxonomy: ProductTaxonomy) => {
2727
logAmplitudeEvent(AnalyticsEvents.FILTER, {
28-
type: taxonomy,
28+
kategori: 'type',
29+
filternavn: taxonomy,
2930
opprinnelse: 'oversiktsside typer',
31+
komponent: 'OverviewTaxonomyFilter',
3032
});
3133
setTaxonomyFilter(taxonomy);
3234
};

src/components/_common/overview-filters/text-filter/OverviewTextFilter.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@ export const OverviewTextFilter = ({ hideLabel }: Props) => {
3636
)
3737
);
3838
logAmplitudeEvent(AnalyticsEvents.FILTER, {
39-
komponent: 'skjemaoversikt-filter',
40-
filtertekst: value,
39+
kategori: 'fritekst',
40+
filternavn: value,
41+
komponent: 'OverviewTextFilter',
4142
});
4243
}, 500),
4344
[setTextFilter]

src/components/parts/filters-menu/FiltersMenuPart.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export const FiltersMenuPart = ({ config, path }: PartComponentProps<PartType.Fi
7070
kategori: category.categoryName,
7171
filternavn: filter.filterName,
7272
opprinnelse: 'filtermeny',
73+
komponent: 'FiltersMenuPart',
7374
});
7475
toggleFilter(filter.id);
7576
};

0 commit comments

Comments
 (0)