Fix sonar-issues

Author: talepre

common/src/client/AppLayout.tsx

@@ -4,7 +4,6 @@ import { AppTopSection } from './top-section/AppTopSection';
 import style from './AppLayout.module.css';
 
 type Props = {
-    siteName: string; // TODO: Can this be removed?
     basePath: string;
     children: React.ReactNode;
     showUnderDevAlert?: boolean;

legacy-archive/client/components/App.tsx

@@ -11,11 +11,11 @@ type Props = {
 };
 
 export const App = ({ appContext }: Props) => {
-    const { cmsName, basePath } = appContext;
+    const { basePath } = appContext;
 
     return (
         <AppStateProvider appContext={appContext}>
-            <AppLayout siteName={cmsName} basePath={basePath}>
+            <AppLayout basePath={basePath}>
                 <SearchStateProvider>
                     <AppLeftSection />
                 </SearchStateProvider>

xp-archive/client/App.tsx

@@ -7,11 +7,7 @@ import { AppStateProvider } from './context/appState/AppStateProvider';
 
 export const App = () => {
     return (
-        <AppLayout
-            siteName={xpArchiveConfig.name}
-            basePath={xpArchiveConfig.basePath}
-            showUnderDevAlert
-        >
+        <AppLayout basePath={xpArchiveConfig.basePath} showUnderDevAlert>
             <AppStateProvider>
                 <NavigationBar />
                 <Content />

xp-archive/client/contentView/pdfExport/PdfExport.tsx

@@ -1,6 +1,6 @@
 import React, { useState } from 'react';
 import { DownloadIcon } from '@navikt/aksel-icons';
-import { Button, Checkbox, CheckboxGroup, Link } from '@navikt/ds-react';
+import { Button, Checkbox, CheckboxGroup } from '@navikt/ds-react';
 import { VersionReference } from 'shared/types';
 import { formatTimestamp } from '@common/shared/timestamp';
 import style from './PdfExport.module.css';

xp-archive/client/versionSelector/VersionSelector.tsx

@@ -1,5 +1,5 @@
-import React, { ChangeEvent, version } from 'react';
-import { Select, UNSAFE_Combobox } from '@navikt/ds-react';
+import React, { ChangeEvent } from 'react';
+import { Select } from '@navikt/ds-react';
 import { VersionReference } from 'shared/types';
 import { pruneString } from '@common/shared/pruneString';
 import { formatTimestamp } from '@common/shared/timestamp';

xp-archive/client/viewSelector/ViewSelector.tsx

@@ -14,6 +14,12 @@ const getDisplayname = (viewVariant: ViewVariant) => {
     return translations[viewVariant];
 };
 
+function getRelevantViewVariants(isWebpage: boolean, hasAttachment: boolean): ViewVariant[] {
+    if (isWebpage) return ['html', 'pdf', 'json'];
+    if (hasAttachment) return ['filepreview', 'json'];
+    return ['json'];
+}
+
 type Props = {
     selectedView: ViewVariant;
     setSelectedView(selectedView: ViewVariant): void;
@@ -32,11 +38,7 @@ export const ViewSelector = ({
         setSelectedView(viewVariant);
     };
 
-    const relevantViewVariants: ViewVariant[] = isWebpage
-        ? ['html', 'pdf', 'json']
-        : hasAttachment
-          ? ['filepreview', 'json']
-          : ['json'];
+    const relevantViewVariants = getRelevantViewVariants(isWebpage, hasAttachment);
 
     return (
         <ToggleGroup