Merge pull request #1454 from navikt/fix/forms-api-filter-out-countries-in-form-translations

Filter out countries in form translations

Author: magnurh-cx

Diff for: packages/bygger/src/context/translations/EditFormTranslationsContext.tsx

@@ -106,5 +106,5 @@ const EditFormTranslationsProvider = ({ initialChanges, children }: Props) => {
 
 const useEditFormTranslations = () => useContext(EditFormTranslationsContext);
 
-export { EditFormTranslationsContext, useEditFormTranslations };
+export { useEditFormTranslations };
 export default EditFormTranslationsProvider;

Diff for: packages/bygger/src/context/translations/EditGlobalTranslationsContext.tsx

@@ -149,5 +149,5 @@ const EditGlobalTranslationsProvider = ({ initialChanges, children }: Props) =>
 
 const useEditGlobalTranslations = () => useContext(EditGlobalTranslationsContext);
 
-export { EditGlobalTranslationsContext, useEditGlobalTranslations };
+export { useEditGlobalTranslations };
 export default EditGlobalTranslationsProvider;

Diff for: packages/bygger/src/translations/utils/editFormTranslationsUtils.ts

@@ -1,3 +1,4 @@
+import { getCountries } from '@navikt/skjemadigitalisering-shared-components';
 import { Form, FormsApiFormTranslation, FormsApiGlobalTranslation } from '@navikt/skjemadigitalisering-shared-domain';
 import { getFormTexts } from '../../old_translations/utils';
 
@@ -29,11 +30,18 @@ const generateAndPopulateTranslationsForForm = (
   globalTranslations: Record<string, FormsApiGlobalTranslation>,
 ): FormsApiFormTranslation[] => {
   const textObjects = getFormTexts(form, false);
+  const countries = getCountries('nb');
 
-  return textObjects.map(({ text }) => {
-    const populatedTranslation = populateFromStoredTranslations(text, storedTranslations);
-    return checkForGlobalOverride(populatedTranslation, globalTranslations);
-  });
+  return (
+    textObjects
+      // We filter out any country names to avoid having to maintain their translations
+      // All country names on 'nn' and 'en' are added from a third party package when we build the i18n object in FyllUt
+      .filter(({ text }) => !countries.some((country) => country.label === text))
+      .map(({ text }) => {
+        const populatedTranslation = populateFromStoredTranslations(text, storedTranslations);
+        return checkForGlobalOverride(populatedTranslation, globalTranslations);
+      })
+  );
 };
 
 export { generateAndPopulateTranslationsForForm };