perf: move some responsibilities out of recursive function (#17)

* perf: move checks out of recursive function call

restructures responsibilities to the reduce count of some checks

improves performance and reduce bundle size

* perf(validation): drop custom integer validation

drops integer validation in favour of inbuilt js array length checks

* refactor: rename variable for clarity

* refactor: refactor top-level conditional

Author: neefrehman

.github/workflows/setup-node-and-test.yml

@@ -48,11 +48,11 @@ jobs:
               run: npm run build
             - name: validate build
               run: |
-                FILE=lib/index.js 
-                FILE2=lib/index.d.ts
-                if [ -f $FILE ] && [ -f $FILE2 ]; then echo "Files exist" 
-                else echo "Files do not exist" && exit 1
-                fi
+                  FILE=lib/index.js 
+                  FILE2=lib/index.d.ts
+                  if [ -f $FILE ] && [ -f $FILE2 ]; then echo "Files exist" 
+                  else echo "Files do not exist" && exit 1
+                  fi
             - name: lint
               run: npm run lint
             - name: test
@@ -68,4 +68,4 @@ jobs:
               id: benchmark
               run: npm run benchmark:diff:ci
               env:
-                GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

benchmark/run-benchmark.ts

@@ -78,7 +78,7 @@ benny
             ["new", "old", "delta"]
         );
 
-        if (!isInCI) {
+        if (!isInCI || !process.env.GITHUB_TOKEN) {
             return;
         }
 
@@ -89,8 +89,7 @@ benny
             body += `| ${diff.name} | ${diff.new}| ${diff.old} | ${diff.delta} |\n`;
         });
 
-        const octokit = getOctokit(process.env.GITHUB_TOKEN ?? "");
-        await octokit.rest.issues.createComment({
+        await getOctokit(process.env.GITHUB_TOKEN).rest.issues.createComment({
             issue_number: context.issue.number,
             owner: context.repo.owner,
             repo: context.repo.repo,