Skip to content

Commit 3af6b35

Browse files
yt-topicusneilime
authored andcommitted
bump constraint to php84
Signed-off-by: Emilien Escalle <[email protected]>
1 parent 2761c45 commit 3af6b35

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

.github/workflows/__shared-ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
- php-versions: "8.1"
1212
- php-versions: "8.2"
1313
- php-versions: "8.3"
14+
- php-versions: "8.4"
1415
stable: true
1516

1617
runs-on: ubuntu-latest
@@ -34,6 +35,9 @@ jobs:
3435
- name: 👕 Lint
3536
if: matrix.stable
3637
run: composer php-cs-fixer -- --format=checkstyle | tools/vendor/bin/cs2pr
38+
env:
39+
# FIXME: Remove this when PHP CS Fixer will support PHP 8.4
40+
PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.php-versions == '8.4' && '1' || '' }}
3741

3842
- name: 🔬 Rector
3943
id: rector

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
PHP_VERSION=8.3
1+
PHP_VERSION=8.4
22
PROJECT_NAME=$(shell basename $(CURDIR))
33
UID=$(shell id -u)
44
GID=$(shell id -g)
@@ -65,7 +65,7 @@ generate-css-referentials: ## Generate referentials for given PHP version
6565

6666
## Run PHP for given version
6767
define run-php
68-
@docker run -it --rm -v ${PWD}:${PWD} -w ${PWD} "${IMAGE}" $(1)
68+
@docker run -it --rm -v ${PWD}:${PWD} -e PHP_CS_FIXER_IGNORE_ENV=$(if $(filter 8.4,$(PHP_VERSION)),1,) -w ${PWD} "${IMAGE}" $(1)
6969
endef
7070

7171
#############################

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"issues": "https://github.com/neilime/php-css-lint/issues"
2424
},
2525
"require": {
26-
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
26+
"php": "^8.1",
2727
"ext-json": "*"
2828
},
2929
"require-dev": {

0 commit comments

Comments
 (0)