Drop Python 3.8 support (#785)

* Drop Python 3.8 support

3.8 is EOL

* Remove

* Remove 3.8 backwards compat handling

* Use constants for HTTP response codes and methods

* Changelog 3.8 EOL + document tox envs

Author: FlorentinD

CONTRIBUTING.md

@@ -55,7 +55,7 @@ Remember that many community members have become regular contributors and some a
 
 Setting up the Python development environment:
 
- * Install Python 3.8+
+ * Install Python 3.9+
  * [Install pip](https://pip.pypa.io/en/stable/installation/)
  * Install the project's Python dependencies:
    ```bash

changelog.md

@@ -3,6 +3,8 @@
 
 ## Breaking changes
 
+* Drop support for Python `3.8` as its EOL
+
 
 ## New features
 

doc/modules/ROOT/pages/installation.adoc

@@ -19,11 +19,12 @@ The Python client supports the following versions of the other three components:
 | Python Client | GDS version  | Python version | Neo4j Python Driver version
 .1+<.^| 1.13
 .1+<.^| >= 2.6, < 2.11
-.4+<.^| >= 3.8, < 3.13
+.1+<.^| >= 3.9, < 3.13
 .3+<.^| >= 4.4.12, < 6.0.0
 
 .1+<.^| 1.12
 .1+<.^| >= 2.6, < 2.11
+.3+<.^| >= 3.8, < 3.13
 
 .1+<.^| 1.11
 .1+<.^| >= 2.6, < 2.10

doc/tests/test_client_only_endpoints.py

@@ -1,7 +1,6 @@
 import os
 import re
 import sys
-from typing import List
 
 from neo4j import GraphDatabase
 
@@ -34,14 +33,14 @@
 FUNCTION_DEF_PATTERN = re.compile(r"def\s+(\w+)\s*\(")
 
 
-def find_single_client_only_functions(py_file_path: str) -> List[str]:
+def find_single_client_only_functions(py_file_path: str) -> list[str]:
     with open(py_file_path) as f:
         contents = f.read()
         matches = re.finditer(CLIENT_ONLY_PATTERN, contents)
         return [f"{match.group(1)}.{match.group(3)}" for match in matches]
 
 
-def find_client_only_functions() -> List[str]:
+def find_client_only_functions() -> list[str]:
     client_only_functions = []
     for root, dirs, files in os.walk(PROJECT_DIR):
         for file in files:
@@ -52,7 +51,7 @@ def find_client_only_functions() -> List[str]:
     return client_only_functions
 
 
-def find_covered_server_endpoints() -> List[str]:
+def find_covered_server_endpoints() -> list[str]:
     driver = GraphDatabase.driver(URI, auth=AUTH)
     with driver.session() as session:
         all_server_endpoints = session.run("CALL gds.list() YIELD name", {}).data()
@@ -62,7 +61,7 @@ def find_covered_server_endpoints() -> List[str]:
     return [ep["name"] for ep in all_server_endpoints if ep["name"] not in IGNORED_SERVER_ENDPOINTS]
 
 
-def check_rst_files(endpoints: List[str]) -> None:
+def check_rst_files(endpoints: list[str]) -> None:
     not_mentioned = set(endpoints)
 
     for root, _, files in os.walk(RST_DIR):

graphdatascience/algo/algo_proc_runner.py

@@ -1,5 +1,5 @@
 from abc import ABC
-from typing import Any, Dict, Tuple
+from typing import Any
 
 from pandas import DataFrame, Series
 
@@ -12,7 +12,7 @@
 
 class AlgoProcRunner(IllegalAttrChecker, ABC):
     @graph_type_check
-    def _run_procedure(self, G: Graph, config: Dict[str, Any], with_logging: bool = True) -> DataFrame:
+    def _run_procedure(self, G: Graph, config: dict[str, Any], with_logging: bool = True) -> DataFrame:
         params = CallParameters(graph_name=G.name(), config=config)
 
         return self._query_runner.call_procedure(endpoint=self._namespace, params=params, logging=with_logging)
@@ -35,7 +35,7 @@ def __call__(self, G: Graph, **config: Any) -> "Series[Any]":
 
 class GraphSageRunner(AlgoProcRunner):
     @graph_type_check
-    def __call__(self, G: Graph, **config: Any) -> Tuple[GraphSageModel, "Series[Any]"]:
+    def __call__(self, G: Graph, **config: Any) -> tuple[GraphSageModel, "Series[Any]"]:
         result = self._run_procedure(G, config).squeeze()
         model_name = result["modelInfo"]["modelName"]
 

graphdatascience/call_parameters.py

@@ -1,4 +1,5 @@
-from typing import Any, OrderedDict
+from collections import OrderedDict
+from typing import Any
 
 
 class CallParameters(OrderedDict[str, Any]):

graphdatascience/error/endpoint_suggester.py

@@ -1,11 +1,9 @@
-from typing import List
-
 import textdistance
 
 from ..ignored_server_endpoints import IGNORED_SERVER_ENDPOINTS
 
 
-def generate_suggestive_error_message(requested_endpoint: str, all_endpoints: List[str]) -> str:
+def generate_suggestive_error_message(requested_endpoint: str, all_endpoints: list[str]) -> str:
     MIN_SIMILARITY_FOR_SUGGESTION = 0.9
 
     closest_endpoint = None

graphdatascience/graph/base_graph_proc_runner.py

@@ -1,8 +1,7 @@
 import os
 import pathlib
-import sys
 import warnings
-from typing import Any, Dict, List, Optional, Union
+from typing import Any, List, Optional, Union
 
 import pandas as pd
 from multimethod import multimethod
@@ -53,28 +52,22 @@ def __init__(self, query_runner: Any, namespace: str, server_version: ServerVers
 
     @staticmethod
     def _path(package: str, resource: str) -> pathlib.Path:
-        if sys.version_info >= (3, 9):
-            from importlib.resources import files
+        from importlib.resources import files
 
-            # files() returns a Traversable, but usages require a Path object
-            return pathlib.Path(str(files(package) / resource))
-        else:
-            from importlib.resources import path
-
-            # we dont want to use a context manager here, so we need to call __enter__ manually
-            return path(package, resource).__enter__()
+        # files() returns a Traversable, but usages require a Path object
+        return pathlib.Path(str(files(package) / resource))
 
     @client_only_endpoint("gds.graph")
     @compatible_with("construct", min_inclusive=ServerVersion(2, 1, 0))
     def construct(
         self,
         graph_name: str,
-        nodes: Union[DataFrame, List[DataFrame]],
-        relationships: Optional[Union[DataFrame, List[DataFrame]]] = None,
+        nodes: Union[DataFrame, list[DataFrame]],
+        relationships: Optional[Union[DataFrame, list[DataFrame]]] = None,
         concurrency: int = 4,
-        undirected_relationship_types: Optional[List[str]] = None,
+        undirected_relationship_types: Optional[list[str]] = None,
     ) -> Graph:
-        nodes = nodes if isinstance(nodes, List) else [nodes]
+        nodes = nodes if isinstance(nodes, list) else [nodes]
 
         if isinstance(relationships, DataFrame):
             relationships = [relationships]
@@ -365,7 +358,7 @@ def _handle_properties(
         G: Graph,
         properties: Strings,
         entities: Strings,
-        config: Dict[str, Any],
+        config: dict[str, Any],
     ) -> DataFrame:
         params = CallParameters(
             graph_name=G.name(),

graphdatascience/graph/graph_alpha_proc_runner.py

@@ -1,5 +1,5 @@
 import os
-from typing import List, Optional, Union
+from typing import Optional, Union
 
 from pandas import DataFrame
 
@@ -36,13 +36,13 @@ def nodeLabel(self) -> GraphLabelRunner:
     def construct(
         self,
         graph_name: str,
-        nodes: Union[DataFrame, List[DataFrame]],
-        relationships: Union[DataFrame, List[DataFrame]],
+        nodes: Union[DataFrame, list[DataFrame]],
+        relationships: Union[DataFrame, list[DataFrame]],
         concurrency: int = 4,
-        undirected_relationship_types: Optional[List[str]] = None,
+        undirected_relationship_types: Optional[list[str]] = None,
     ) -> Graph:
-        nodes = nodes if isinstance(nodes, List) else [nodes]
-        relationships = relationships if isinstance(relationships, List) else [relationships]
+        nodes = nodes if isinstance(nodes, list) else [nodes]
+        relationships = relationships if isinstance(relationships, list) else [relationships]
 
         errors = []
 

graphdatascience/graph/graph_beta_proc_runner.py

@@ -1,4 +1,4 @@
-from typing import Any, List, Union
+from typing import Any, Union
 
 from ..call_parameters import CallParameters
 from ..error.illegal_attr_checker import IllegalAttrChecker
@@ -9,7 +9,7 @@
 from .graph_object import Graph
 from .graph_project_runner import GraphProjectBetaRunner
 
-Strings = Union[str, List[str]]
+Strings = Union[str, list[str]]
 
 
 class GraphBetaProcRunner(UncallableNamespace, IllegalAttrChecker):

graphdatascience/graph/graph_cypher_runner.py

@@ -2,7 +2,7 @@
 
 import re
 from itertools import chain, zip_longest
-from typing import Any, Dict, Optional
+from typing import Any, Optional
 
 from pandas import Series
 
@@ -45,7 +45,7 @@ def project(
 
         GraphCypherRunner._verify_query_ends_with_return_clause(self._namespace, query)
 
-        result: Optional[Dict[str, Any]] = self._query_runner.run_cypher(query, params, database, False).squeeze()
+        result: Optional[dict[str, Any]] = self._query_runner.run_cypher(query, params, database, False).squeeze()
 
         if not result:
             raise ValueError("Projected graph cannot be empty.")

graphdatascience/graph/graph_entity_ops_runner.py

@@ -1,5 +1,5 @@
 from functools import reduce
-from typing import Any, Dict, List, Type, Union
+from typing import Any, Type, Union
 from warnings import filterwarnings
 
 import pandas as pd
@@ -18,15 +18,15 @@
 from .graph_object import Graph
 from .graph_type_check import graph_type_check
 
-Strings = Union[str, List[str]]
+Strings = Union[str, list[str]]
 
 
 class TopologyDataFrame(DataFrame):
     @property
     def _constructor(self) -> "Type[TopologyDataFrame]":
         return TopologyDataFrame
 
-    def by_rel_type(self) -> Dict[str, List[List[int]]]:
+    def by_rel_type(self) -> dict[str, list[list[int]]]:
         # Pandas 2.2.0 deprecated an internal API used by DF.take(indices)
         filterwarnings(
             "ignore",
@@ -55,7 +55,7 @@ def _handle_properties(
         G: Graph,
         properties: Strings,
         entities: Strings,
-        config: Dict[str, Any],
+        config: dict[str, Any],
     ) -> DataFrame:
         params = CallParameters(
             graph_name=G.name(),
@@ -78,7 +78,7 @@ def stream(
         G: Graph,
         node_property: str,
         node_labels: Strings = ["*"],
-        db_node_properties: List[str] = [],
+        db_node_properties: list[str] = [],
         **config: Any,
     ) -> DataFrame:
         self._namespace += ".stream"
@@ -96,10 +96,10 @@ class GraphNodePropertiesRunner(GraphEntityOpsBaseRunner):
     def stream(
         self,
         G: Graph,
-        node_properties: List[str],
+        node_properties: list[str],
         node_labels: Strings = ["*"],
         separate_property_columns: bool = False,
-        db_node_properties: List[str] = [],
+        db_node_properties: list[str] = [],
         **config: Any,
     ) -> DataFrame:
         self._namespace += ".stream"
@@ -113,11 +113,11 @@ def stream(
     @staticmethod
     def _process_result(
         query_runner: QueryRunner,
-        node_properties: List[str],
+        node_properties: list[str],
         separate_property_columns: bool,
-        db_node_properties: List[str],
+        db_node_properties: list[str],
         result: DataFrame,
-        config: Dict[str, Any],
+        config: dict[str, Any],
     ) -> DataFrame:
         # new format was requested, but the query was run via Cypher
         if separate_property_columns and "propertyValue" in result.keys():
@@ -161,7 +161,7 @@ def _process_result(
         return result
 
     @staticmethod
-    def _build_query(db_node_properties: List[str]) -> str:
+    def _build_query(db_node_properties: list[str]) -> str:
         query_prefix = "MATCH (n) WHERE id(n) IN $ids RETURN id(n) AS nodeId"
 
         def add_property(query: str, prop: str) -> str:
@@ -176,7 +176,7 @@ def write(self, G: Graph, node_properties: Strings, node_labels: Strings = ["*"]
 
     @compatible_with("drop", min_inclusive=ServerVersion(2, 2, 0))
     @graph_type_check
-    def drop(self, G: Graph, node_properties: List[str], **config: Any) -> "Series[Any]":
+    def drop(self, G: Graph, node_properties: list[str], **config: Any) -> "Series[Any]":
         self._namespace += ".drop"
         params = CallParameters(
             graph_name=G.name(),
@@ -205,7 +205,7 @@ class GraphRelationshipPropertiesRunner(GraphEntityOpsBaseRunner):
     def stream(
         self,
         G: Graph,
-        relationship_properties: List[str],
+        relationship_properties: list[str],
         relationship_types: Strings = ["*"],
         separate_property_columns: bool = False,
         **config: Any,
@@ -239,7 +239,7 @@ def write(
         self,
         G: Graph,
         relationship_type: str,
-        relationship_properties: List[str],
+        relationship_properties: list[str],
         **config: Any,
     ) -> "Series[Any]":
         self._namespace += ".write"
@@ -319,7 +319,7 @@ def drop(
 
     @compatible_with("stream", min_inclusive=ServerVersion(2, 5, 0))
     @graph_type_check
-    def stream(self, G: Graph, relationship_types: List[str] = ["*"], **config: Any) -> TopologyDataFrame:
+    def stream(self, G: Graph, relationship_types: list[str] = ["*"], **config: Any) -> TopologyDataFrame:
         self._namespace += ".stream"
         params = CallParameters(graph_name=G.name(), relationship_types=relationship_types, config=config)
         result = self._query_runner.call_procedure(endpoint=self._namespace, params=params)
@@ -336,7 +336,7 @@ def toUndirected(self) -> ToUndirectedRunner:
 class GraphRelationshipsBetaRunner(GraphEntityOpsBaseRunner):
     @compatible_with("stream", min_inclusive=ServerVersion(2, 2, 0))
     @graph_type_check
-    def stream(self, G: Graph, relationship_types: List[str] = ["*"], **config: Any) -> TopologyDataFrame:
+    def stream(self, G: Graph, relationship_types: list[str] = ["*"], **config: Any) -> TopologyDataFrame:
         self._namespace += ".stream"
         params = CallParameters(graph_name=G.name(), relationship_types=relationship_types, config=config)
 

graphdatascience/graph/graph_export_runner.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict
+from typing import Any
 
 from pandas import Series
 
@@ -15,7 +15,7 @@ def __call__(self, G: Graph, **config: Any) -> "Series[Any]":
         return self._export_call(G, config)
 
     @graph_type_check
-    def _export_call(self, G: Graph, config: Dict[str, Any]) -> "Series[Any]":
+    def _export_call(self, G: Graph, config: dict[str, Any]) -> "Series[Any]":
         params = CallParameters(graph_name=G.name(), config=config)
         return self._query_runner.call_procedure(endpoint=self._namespace, params=params).squeeze()  # type: ignore
 
@@ -39,7 +39,7 @@ def __call__(self, G: Graph, **config: Any) -> "Series[Any]":
         return self._export_call(G, config)
 
     @graph_type_check
-    def _export_call(self, G: Graph, config: Dict[str, Any]) -> "Series[Any]":
+    def _export_call(self, G: Graph, config: dict[str, Any]) -> "Series[Any]":
         params = CallParameters(graph_name=G.name(), config=config)
         return self._query_runner.call_procedure(endpoint=self._namespace, params=params).squeeze()  # type: ignore