Fix interface injection deduplication when all injected interfaces are already present (#58)

Author: shartte

interfaceinjection/src/main/java/net/neoforged/jst/interfaceinjection/InjectInterfacesVisitor.java

@@ -79,6 +79,10 @@ private void inject(PsiClass psiClass, Collection<String> targets) {
                 .sorted(Comparator.naturalOrder())
                 .collect(Collectors.joining(", "));
 
+        if (interfaceImplementation.isEmpty()) {
+            return; // Nothing to do, all injected interfaces are already present
+        }
+
         if (implementsList.getChildren().length == 0) {
             StringBuilder text = new StringBuilder();
 

tests/data/interfaceinjection/deduplication/expected/pkg/Example.java

@@ -0,0 +1,6 @@
+package pkg;
+
+import java.util.Set;
+
+public class Example implements Set {
+}

tests/data/interfaceinjection/deduplication/injectedinterfaces.json

@@ -0,0 +1,3 @@
+{
+  "pkg/Example": "java/util/Set"
+}

tests/data/interfaceinjection/deduplication/source/pkg/Example.java

@@ -0,0 +1,6 @@
+package pkg;
+
+import java.util.Set;
+
+public class Example implements Set {
+}

tests/src/test/java/net/neoforged/jst/tests/EmbeddedTest.java

@@ -316,6 +316,11 @@ void testSimpleInjection() throws Exception {
             runInterfaceInjectionTest("simple_injection", tempDir);
         }
 
+        @Test
+        void testDeduplication() throws Exception {
+            runInterfaceInjectionTest("deduplication", tempDir);
+        }
+
         @Test
         void testAdditiveInjection() throws Exception {
             runInterfaceInjectionTest("additive_injection", tempDir);