NF 26.1.0.0-alpha.9+snapshot-6 :applyNeoforgePatches failed

[burningtnt]

In NeoForge 26.1.0.0-alpha.9+snapshot-6 moddev 2.0.140, :applyNeoforgePatches failed in development environment.

> Configure project :
Parsed unknown MC version 26.1-snapshot-6 from NeoForge version 26.1.0.0-alpha.9+snapshot-6. Using capabilities of latest known Minecraft version 26.1-snapshot-2 with an updated Minecraft version.

> Task :createMinecraftArtifacts
Loaded 141 artifacts from D:\PYL\Projects\NotEnoughBandwidth-New\build\tmp\createMinecraftArtifacts\nfrt_artifact_manifest.properties
*** Started working on downloadManifest
  ↓ https://launchermeta.mojang.com/mc/game/version_manifest_v2.json
 ✓ Completed downloadManifest in 1.42s
*** Started working on downloadJson
 ✓ Completed downloadJson in 0.01s
*** Started working on downloadServer
*** Started working on downloadClient
 ✓ Completed downloadServer in 0.08s
 ✓ Completed downloadClient in 0.08s
*** Started working on preProcessJar
 ♻ Used cache of preProcessJar in 0.00s
*** Started working on decompile
 ♻ Used cache of decompile in 0.00s
*** Started working on patch
 ♻ Used cache of patch in 0.00s
*** Started working on applyNeoforgePatches
 ↳ Running external tool io.codechicken:DiffPatch:2.0.0.36:all
Last lines of D:\PYL\Projects\NotEnoughBandwidth-New\build\tmp\neoformruntime\20260207-174612_applyNeoforgePatches\console_output.txt:
------------------------------------------------------------
:
 - C:\Program Files\BellSoft\LibericaJDK-25-Full\bin\java.exe
 - --sun-misc-unsafe-memory-access=allow
 - -jar
 - C:\Users\Jacky\.gradle\caches\modules-2\files-2.1\io.codechicken\DiffPatch\2.0.0.36\5b32f9baa0c0371c0dc80a3b88794960af0c6b44\DiffPatch-2.0.0.36-all.jar
 - C:\Users\Jacky\.gradle\caches\neoformruntime\intermediate_results\patch_4e75fcf050654b5f69a1c21df8a2c330ca13085a_output.zip
 - C:\Users\Jacky\.gradle\caches\modules-2\files-2.1\net.neoforged\neoforge\26.1.0.0-alpha.9+snapshot-6\251ef5c5731ca28611e7e6faaf3bf3ee032d1f01\neoforge-26.1.0.0-alpha.9+snapshot-6-userdev.jar
 - --prefix
 - patches/
 - --patch
 - --archive
 - ZIP
 - --output
 - ./output.zip
 - --log-level
 - WARN
 - --mode
 - OFFSET
 - --archive-rejects
 - ZIP
 - --reject
 - ./outputRejects.zip
 - --base-path-prefix
 - a/
 - --modified-path-prefix
 - b/
--------------------------------------------------------------------------------

[WARN] Patching: net/minecraft/resources/Identifier.java
[WARN]  Hunk 0: FAILURE: @@ -150,6 +150,12 @@

------------------------------------------------------------
net.neoforged.neoform.runtime.graph.NodeExecutionException: Node action for applyNeoforgePatches failed
	at net.neoforged.neoform.runtime.engine.NeoFormEngine.runNode(NeoFormEngine.java:612)
	at net.neoforged.neoform.runtime.engine.NeoFormEngine.lambda$getWaitCondition$5(NeoFormEngine.java:558)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1825)
	at java.base/java.util.concurrent.ThreadPerTaskExecutor$TaskRunner.run(ThreadPerTaskExecutor.java:291)
	at java.base/java.lang.VirtualThread.run(VirtualThread.java:456)
Caused by: java.lang.RuntimeException: Failed to execute tool
	at net.neoforged.neoform.runtime.actions.ExternalJavaToolAction.run(ExternalJavaToolAction.java:206)
	at net.neoforged.neoform.runtime.engine.NeoFormEngine.runNode(NeoFormEngine.java:601)
	... 4 more

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':createMinecraftArtifacts'.
> Process 'command 'C:\Program Files\BellSoft\LibericaJDK-25-Full\bin\java.exe'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to generate a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

BUILD FAILED in 19s
Total runtime: 17.55s


> Task :createMinecraftArtifacts FAILED

[Incubating] Problems report is available at: file:///D:/PYL/Projects/NotEnoughBandwidth-New/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.2.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
1 actionable task: 1 executed

I've tried again after removing all cache files, however the error remains.

[noobanidus]

The patch's resolveAgainst method appears to have some sort of varargs-coercion-array-construction with new String[]{this.getPath()}, versus what the actual decompiled code has, which is to just pass this.getPath() in. Is it possible that the patch was created by comparing against a weirdly-decompiled method?

The issue appears to be vineflower decompiling the project while running Java 21, which produces the non-vararg variant which causes the patch to be rejected.

Wiping the caches and ensuring Vineflower decompiles with Java 25 seems to resolve the issue.

[burningtnt]

Wiping the caches and ensuring Vineflower decompiles with Java 25 seems to resolve the issue.

I located ConsoleDecompiler JVM and then ran jcmd <pid> VM.info. It's already Java 25.

[noobanidus]

Hm. My method was to run setup in the NeoForge port/26.1 branch. Maybe there's something specific as to how NeoForge's setup is decompiling things?

[burningtnt]

For the time being, developers could modify net/minecraft/resource/Identifier.java in the patch_xxxxxx_output.zip manually to make it match with the patch here so applyNeoForgePatches can succeed.

[teddyxlandlee]

Can reproduce.

2026-02-07T22:25:01.503+0800 [ERROR] [system.err] [WARN] Patching: net/minecraft/resources/Identifier.java
2026-02-07T22:25:01.503+0800 [ERROR] [system.err] [WARN]  Hunk 0: FAILURE: @@ -150,6 +150,12 @@

It seems that these lines are the problem.

[ApexModder]

This should be fixed with #2957 and snapshot 6 should now be importable with version 26.1.0.0-alpha.10+snapshot-6

[Technici4n]

A proper fix needs to be implemented in MDG still, this was just a workaround.