-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update missing_device_type_components.py to check more than just names #77
Comments
Hey Ryan, just throwing this here as well since sometimes things get buried in slack. Maybe you can build a hash table rather than using nested for loops? Data structures has never been my forte, but I do recall some of the math. Those 4 nested for loops are probably creating a lot of time complexity |
I think this should be a separate report, because there are two distinct things you might want to do:
That is: you may have intentionally changed something from the device type in a specific device, and don't want to be prompted about it all the time. |
Good point. So a name focused Class like the original and a full detail Class. |
Using @kkthxbye-code https://gist.github.com/kkthxbye-code/6d6f017e590d3271cbd1071fcb4840be as an example to refactor |
Update missing_device_type_components.py to check more than just names of items.
The text was updated successfully, but these errors were encountered: