Closes #19523: Add device_count and module_count filter for DeviceType and ModuleType #20718
+108
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `device_count` and `module_count` filters to enable queries based on the existence and count of the associated device or module instances. Updates forms, filtersets, and GraphQL schema to support these filters, along with comprehensive tests for validation. Fixes netbox-community#19523
Updates `connect_counters` to prevent duplicate signal handlers by using consistent `dispatch_uid` values per sender. Adds a check to avoid reconnecting models already processed during registration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19523
Summary (draft)
Implement usage count filtering via counter caches:
device_countto DeviceType andmodule_countto ModuleType usingCounterCacheFielddevice_count__gte=…,deviceCount: { gte: … }).device_count) as discussed; introducemodule_countfor consistency.Note on receivers (included so CI passes on
feature)This draft includes the per‑sender
dispatch_uidchange toutilities.counters.connect_counters()to prevent duplicate signal registration (see #20697). I’ll rebase/drop this once #20697 merges tomain.Status
Tests are pending! Opening as a draft to validate the approach and naming before finalizing.