Skip to content

Commit 1e4b596

Browse files
committed
GUI: Improve object deletion UX when no object exists
1 parent 23ecad4 commit 1e4b596

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

npbackup/gui/config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,10 @@ def create_object(full_config: dict) -> dict:
199199

200200
def delete_object(full_config: dict, full_object_name: str) -> dict:
201201
object_type, object_name = get_object_from_combo(full_object_name)
202-
result = sg.PopupYesNo(
202+
if not object_type and not object_name:
203+
sg.popup_error(_t("config_gui.no_object_to_delete"), keep_on_top=True)
204+
return full_config
205+
result = sg.popup_yes_no(
203206
_t("config_gui.are_you_sure_to_delete") + f" {object_type} {object_name} ?"
204207
)
205208
if result == "Yes":

npbackup/translations/config_gui.en.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ en:
136136
add_object: Add another repo or group
137137
delete_object: Delete selected repo or group
138138
are_you_sure_to_delete: Are you sure you want to delete
139+
no_object_to_delete: No object to delete
139140
repo_already_exists: Repo already exists
140141
group_already_exists: Group already exists
141142
cannot_remove_group_inherited_settings: Cannot remove group inherited settings. Please remove directly in group configuration

npbackup/translations/config_gui.fr.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ fr:
137137
add_object: Ajouter un autre dépot ou groupe
138138
delete_object: Supprimer le dépot ou groupe actuel
139139
are_you_sure_to_delete: Êtes-vous sûr de vouloir supprimer le
140+
no_object_to_delete: Aucun objet à supprimer
140141
repo_already_exists: Dépot déjà existant
141142
group_already_exists: Groupe déjà existant
142143
cannot_remove_group_inherited_settings: Impossible de supprimer une option héritée de groupe. Veuillez supprimer l'option directement dans la configuration de groupe

0 commit comments

Comments
 (0)