fix: suppress spinner in netlify watch with --silent or --json flag

The netlify watch command shows an animated spinner while waiting for
deploys to complete. This is annoying for users who switch away from
the terminal (e.g., in tmux) since the spinner constantly updates and
marks the window as having new output even though nothing useful changed.

This PR suppresses the spinner when --silent or --json is passed,
allowing users to run netlify watch --silent for a quiet mode that
only prints when a deploy completes.

Fixes #5301

Author: HosnainRafi

src/commands/watch/watch.ts

@@ -15,7 +15,7 @@ const BUILD_FINISH_INTERVAL = 1e3
 // 20 minutes
 const BUILD_FINISH_TIMEOUT = 12e5
 
-const waitForBuildFinish = async function (api: NetlifyAPI, siteId: string, spinner: Spinner) {
+const waitForBuildFinish = async function (api: NetlifyAPI, siteId: string, spinner: Spinner | undefined) {
   let firstPass = true
 
   const waitForBuildToFinish = async function () {
@@ -27,7 +27,11 @@ const waitForBuildFinish = async function (api: NetlifyAPI, siteId: string, spin
     // @TODO implement build error messages into this
 
     if (!currentBuilds || currentBuilds.length === 0) {
-      stopSpinner({ spinner })
+      if (spinner) {
+        stopSpinner({ spinner })
+      } else {
+        log('Waiting for active project deploys to complete... done')
+      }
       return true
     }
     firstPass = false
@@ -46,7 +50,7 @@ const waitForBuildFinish = async function (api: NetlifyAPI, siteId: string, spin
   return firstPass
 }
 
-export const watch = async (_options: unknown, command: BaseCommand) => {
+export const watch = async (options: { silent?: boolean; json?: boolean }, command: BaseCommand) => {
   await command.authenticate()
   const client = command.netlify.api
   let siteId = command.netlify.site.id
@@ -80,7 +84,11 @@ export const watch = async (_options: unknown, command: BaseCommand) => {
   //     "created_at": "2018-07-17T17:14:03.423Z"
   // }
   //
-  const spinner = startSpinner({ text: 'Waiting for active project deploys to complete' })
+  // Allow suppressing the spinner via --silent or --json (see #5301)
+  const suppressSpinner = options?.silent || options?.json
+  const spinner = suppressSpinner
+    ? undefined
+    : startSpinner({ text: 'Waiting for active project deploys to complete' })
   try {
     // Fetch all builds!
     // const builds = await client.listSiteBuilds({siteId})