Skip to content

I think a lot of private members should be declared protected #169

@etranger

Description

@etranger

Lack of or incomplete support of certain features (nullable typed class constants in my case) makes it tempting to extend the base Printer class and introduce my own implementation, but it's very hard due to massive internal dependencies on private methods.

Declaring PsrPrinter class as final also makes it a deadend in terms of extensibility.

Simply changing private methods to protected, and removing final from PstPrinter would greatly improve extensibility of the library without compromising... well, anything.

As a sidenote, support for nullable typed class constants would be a welcome addition.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions