Fixed excessive redraw on GFX menu

Field range validation
etc...

Author: neu-rah

menu.cpp

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 Arduino generic menu system
 */
@@ -30,14 +30,14 @@ int menu::menuKeys(menuOut &p,Stream& c,bool canExit) {
         if (sel>0) {
           sel--;
           if (sel+1>=p.maxY) p.top=sel-p.maxY;
-          p.drawn=0;
+          //p.drawn=0;
           //printMenu(p,canExit);
         }
       } else if (ch=='+') {
         if (sel<(sz-(canExit?0:1))) {
           sel++;
           if ((sz-sel+(canExit?1:0))>=p.maxY) p.top=sel-(canExit?1:0);
-          p.drawn=0;
+          //p.drawn=0;
           //printMenu(p,canExit);
         }
       } else if (ch==27) {
@@ -64,7 +64,7 @@ void menu::activate(menuOut& p,Stream& c,bool canExit) {
 		activeNode=this;
 		sel=0;
 		p.top=0;
-   	p.drawn=0;//redraw menu
+   	//p.drawn=0;//redraw menu
    	this->canExit=canExit;
 	}
   int op=-1;

menu.h

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 Arduino generic menu system
 
@@ -15,8 +15,8 @@ Arduino generic menu system
  menuPrint: menuOut implementation for generic print (as Serial)
    menuLCD: menuOut implementation for standard LiquidCrystal LCD
 
-the menu system will read provided stream for input, it works for Serial
-for encoders, joysticks, keyboards or touch a stream must be made out of them
+the menu system will read provided stream for input, it works for Serial,
+encoders, joysticks, keyboards (or touch?) a stream must be made out of them
 */
 #ifndef RSITE_ARDUINOP_MENU_SYSTEM
   #define RSITE_ARDUINOP_MENU_SYSTEM
@@ -142,6 +142,9 @@ for encoders, joysticks, keyboards or touch a stream must be made out of them
     //device resolution
     int resX;
     int resY;
+    //preventing uneeded redraws
+    int lastTop;
+    int lastSel;
     menuOut(int x=0x7F,int y=0x7F,int resX=1,int resY=1)
     	:maxX(x),maxY(y),top(0),resX(resX),resY(resY),drawn(0) {}
     virtual void clear()=0;

menuGFX.h

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 Use graphics screens (adafruit library based) as menu output
 ***/
@@ -30,8 +30,6 @@ Use graphics screens (adafruit library based) as menu output
 
   class menuGFX:public menuOut {
     public:
-    int lastTop;
-    int lastSel;
     uint16_t bgColor;
     uint16_t enabledColor;
     uint16_t disabledColor;
@@ -69,14 +67,18 @@ Use graphics screens (adafruit library based) as menu output
     	println();
     }
 		virtual void printMenu(menu& m,bool drawExit) {
-			if (drawn!=&m) clear();
+			if (drawn!=&m) clear();//clear all screen when changing menu
 			if (m.sel-top>=maxY) top=m.sel-maxY+1;//selected option outside device (bottom)
 			else if (m.sel<top) top=m.sel;//selected option outside device (top)
 			int i=0;for(;i<m.sz;i++) {
 				if ((i>=top)&&((i-top)<maxY)) {
 				  if(i-top>=maxY) break;
-				  if ((top!=lastTop)||(i==m.sel)||(i==lastSel)||(drawn!=&m))
+				  if ((drawn!=&m)||(top!=lastTop)||(m.sel!=lastSel&&((i==m.sel)||(i==lastSel)))) {
+				  	Serial<<hex((long)drawn)<<" <-> "<<hex((long)&m)
+				  		<<(drawn!=&m)<<(top!=lastTop)<<(m.sel!=lastSel&&((i==m.sel)||(i==lastSel)))
+					  	<<" drawing option:"<<m.data[i]->text<<endl;
 				  	print(*m.data[i],i==m.sel,i+1,i-top,m.width);
+				  }
 				}
 			}
 			if (drawExit&&i-top<maxY&&((top!=lastTop)||(i==m.sel)||(i==lastSel)||(drawn!=&m)))

menuLCD.h

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 Use standard arduino LCD (LiquidCrystal library) as menu output
 ***/

menuLCDs.h

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 implement menu output for Francisco Malpartida arduino LCD's 
  

menuPrint.h

@@ -5,7 +5,7 @@ This software is furnished "as is", without technical support, and with no
 warranty, express or implied, as to its usefulness for any purpose.
 
 Thread Safe: No
-Extendable: Yes
+Extensible: Yes
 
 menu output to Print device (ex: Serial)
 ***/