Skip to content

Conversation

DaltheCow
Copy link
Collaborator

No description provided.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14984136606/artifacts/3110197859.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14984174171/artifacts/3110207526.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14984211011/artifacts/3110219786.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/14984338662/artifacts/3110262102.
They will be retained for up to 30 days.

@DaltheCow DaltheCow added the UI Front-end workstream label May 13, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15000866611/artifacts/3115819899.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15000916175/artifacts/3115838945.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15001083451/artifacts/3115899293.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15001120076/artifacts/3115912254.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15001226875/artifacts/3115954183.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15001411218/artifacts/3116022886.
They will be retained for up to 30 days.

@DaltheCow DaltheCow force-pushed the core-framework-setup branch from 17e0547 to 026a13f Compare May 13, 2025 16:16
@DaltheCow DaltheCow force-pushed the core-framework-setup branch from 4bdf717 to b8bf83c Compare May 30, 2025 19:27

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354199984/artifacts/3231152192.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354245453/artifacts/3231168863.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354280096/artifacts/3231183098.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354294041/artifacts/3231187193.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354386568/artifacts/3231220281.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354401466/artifacts/3231224992.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15354531306/artifacts/3231277509.
They will be retained for up to 30 days.

@markurtz markurtz requested review from markurtz and Copilot May 30, 2025 20:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up core framework pieces for the UI directory by introducing and updating configuration files for TypeScript, ESLint, Prettier, husky precommit hooks, and GitHub Actions workflows.

  • Updated tsconfig.json with additional compiler options and revised include/exclude paths
  • Refined linting and formatting configurations in ESLint, Prettier files, and package.json
  • Added a new GitHub Actions workflow for quality and precommit checks

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ui/tsconfig.json Added/modified compiler options and include/exclude settings
src/ui/next.config.ts Standardized quotes and formatting
src/ui/app/page.tsx Updated to single quotes and simplified Image component usage
src/ui/app/layout.tsx Updated quoting style and simplified props destructuring
src/ui/.prettierrc Added Prettier configuration file
src/ui/.prettierignore Added file ignoring configuration for Prettier
src/ui/.eslintrc.json Expanded ESLint configuration with additional plugins and rules
src/ui/.eslintignore Added file ignoring configuration for ESLint
package.json Updated dependencies and added new scripts
.github/workflows/ui-development.yml Introduced a new GitHub Actions workflow for UI checks
Comments suppressed due to low confidence (2)

src/ui/tsconfig.json:5

  • The update of 'baseUrl' from 'src/ui' to './src/' alters module resolution paths; please verify that all imports are adjusted accordingly.
    "baseUrl": "./src/",

package.json:36

  • If TSLint is no longer used in favor of ESLint, consider removing 'tslint-config-prettier' to avoid maintaining unused dependencies.
    "tslint-config-prettier": "^1.18.0",

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15355230410/artifacts/3231538681.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15355265993/artifacts/3231550902.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15355300874/artifacts/3231562395.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15401715146/artifacts/3244469442.
They will be retained for up to 30 days.

@DaltheCow
Copy link
Collaborator Author

@markurtz
Should be all good to go!

2 things. jest and testing set up is in the next PR, you mentioned jest in one comment so wanted to call that out
In the last PR you mentioned adding things like linting for "no-unused-variables". Lots of those types of things are included in some of the extensions/plugins. You mentioned checking for other things we could include and might be missing there. In the past you requested a few things we added in such as the complexity rules, import order, no secrets. Maybe some others that are included.

AI chat suggests a bunch more things that can be added on. I guess it'd feel weird to just add them all because it said so. But looking into it right now.

@markurtz markurtz merged commit 0409b28 into main Jun 2, 2025
13 checks passed
@markurtz markurtz deleted the core-framework-setup branch June 2, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Front-end workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants