-
Notifications
You must be signed in to change notification settings - Fork 72
Set up core framework pieces such as configs for eslint, typescript, prettier, husky precommit hook, basic GHA #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
17e0547
to
026a13f
Compare
4bdf717
to
b8bf83c
Compare
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets up core framework pieces for the UI directory by introducing and updating configuration files for TypeScript, ESLint, Prettier, husky precommit hooks, and GitHub Actions workflows.
- Updated tsconfig.json with additional compiler options and revised include/exclude paths
- Refined linting and formatting configurations in ESLint, Prettier files, and package.json
- Added a new GitHub Actions workflow for quality and precommit checks
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/ui/tsconfig.json | Added/modified compiler options and include/exclude settings |
src/ui/next.config.ts | Standardized quotes and formatting |
src/ui/app/page.tsx | Updated to single quotes and simplified Image component usage |
src/ui/app/layout.tsx | Updated quoting style and simplified props destructuring |
src/ui/.prettierrc | Added Prettier configuration file |
src/ui/.prettierignore | Added file ignoring configuration for Prettier |
src/ui/.eslintrc.json | Expanded ESLint configuration with additional plugins and rules |
src/ui/.eslintignore | Added file ignoring configuration for ESLint |
package.json | Updated dependencies and added new scripts |
.github/workflows/ui-development.yml | Introduced a new GitHub Actions workflow for UI checks |
Comments suppressed due to low confidence (2)
src/ui/tsconfig.json:5
- The update of 'baseUrl' from 'src/ui' to './src/' alters module resolution paths; please verify that all imports are adjusted accordingly.
"baseUrl": "./src/",
package.json:36
- If TSLint is no longer used in favor of ESLint, consider removing 'tslint-config-prettier' to avoid maintaining unused dependencies.
"tslint-config-prettier": "^1.18.0",
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
@markurtz 2 things. jest and testing set up is in the next PR, you mentioned jest in one comment so wanted to call that out AI chat suggests a bunch more things that can be added on. I guess it'd feel weird to just add them all because it said so. But looking into it right now. |
No description provided.