glamor/dri3: misc fixes for intel xe drm driver#423
Open
FlyGoat wants to merge 3 commits into
Open
Conversation
Move screen backing allocation into shared RandR helpers, keep a software bounce buffer for CPU access, and create the glamor screen pixmap from a GBM BO. GBM is available across all DRM drivers supported by xorgxrdp, so it provides a common allocation path for the glamor screen backing store. Allocate the BO with GBM_BO_USE_SCANOUT as well as GBM_BO_USE_RENDERING. It appears GBM_BO_USE_SCANOUT is needed to keep the Intel xe driver happy, even though the BO is only used as the glamor screen backing store. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Render nodes do not require DRM authentication and report EACCES from drmGetMagic(), but primary nodes still need the client fd to be authenticated against the server DRM fd before it is returned to DRI3. Handle both cases in rdpDri3OpenClient() so client buffer sharing works regardless of which DRM node xorgxrdp is configured to use. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Use libdrm helpers to query the DRM device version instead of issuing DRM_IOCTL_VERSION directly during glamor device probing. This keeps the existing detection logic while avoiding raw ioctl usage for better portability across DRM environments. Also open the DRM fd with O_CLOEXEC. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Member
Author
|
@matt335672 Oops it's intel's new experimental drm driver. |
FlyGoat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While getting xorgxrdp working on xe, I hit a few issues in the glamor/DRI3 path.
This series:
With these patches applied, xorgxrdp works for me on xe.