Skip to content

Commit 14a07ab

Browse files
committed
fix
1 parent 2656a96 commit 14a07ab

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/samplers/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ distributed_tracing:
6868

6969
## Solution
7070

71-
There are three sampler modes, each with three sampler sections, resulting in potentially nine different sampling decisions that the agent would have to support.
72-
73-
We create a new `Sampler` instance (`AdaptiveSampler`, `AlwaysOnSampler`, `AlwaysOffSampler`, or `TraceIdRatioBasedSampler`, defined in this folder) for each sampler modes' section, resulting in 9 samplers.
71+
There are three sampler modes, each with three sampler sections, resulting in potentially nine different sampling decisions that the agent would have to support. We create a new `Sampler` instance (`AdaptiveSampler`, `AlwaysOnSampler`, `AlwaysOffSampler`, or `TraceIdRatioBasedSampler`, defined in this folder) for each of these sampler modes' sections.
7472

7573
`agent.sampler` would be defined as:
7674

@@ -87,6 +85,6 @@ These fields currently exist (before core tracing was implemented); `agent.sampl
8785
* `agent.sampler.remoteParentSampled`
8886
* `agent.sampler.remoteParentNotSampled`
8987

90-
These samplers have a `applySamplingDecision({transaction})` function, which `Transaction` calls (in `lib/transaction/index.js`) to updated its `sampled` field and therefore its `priority`.
88+
These samplers have a `applySamplingDecision({transaction})` function, which `Transaction` calls (in `lib/transaction/index.js`) to update its `sampled` field and therefore its `priority`.
9189

9290
Unlike the other samplers, the `AdaptiveSampler` must share state with other `AdaptiveSamplers` with the same `sampling_target`, which complicates our seperate sampler instances approach. This will be fixed shortly, and this document will be updated to describe that solution.

0 commit comments

Comments
 (0)