Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element spacing should use multiples of --default-grid-baseline #9944

Open
ChristophWurst opened this issue Jul 30, 2024 · 0 comments · May be fixed by #10919
Open

Element spacing should use multiples of --default-grid-baseline #9944

ChristophWurst opened this issue Jul 30, 2024 · 0 comments · May be fixed by #10919
Assignees
@GVodyanov
Labels
3. to review bug design

Comments

@ChristophWurst
Copy link
Member

Steps to reproduce

  1. Inspect the app DOM

Expected behavior

Spacing uses multiples of var(--default-grid-baseline)

Actual behavior

Spacing in this app uses "magic" numbers like 24px, 10px, etc

Mail app version

No response

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response
This was referenced Jul 30, 2024
Closed
Merged
@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Jul 30, 2024
@GVodyanov GVodyanov self-assigned this Mar 6, 2025
This was referenced Mar 22, 2025
Open
Merged
@GVodyanov GVodyanov moved this from 📄 To do to 🏗️ In progress in 💌 📅 👥 Groupware team Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GVodyanov GVodyanov

Labels
3. to review bug design
Projects
💌 📅 👥 Groupware team
Status: 🏗️ In progress
🖍 Design team
Status: 👓 Design review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use css variables instead of magic numbers nextcloud/mail
2 participants
@ChristophWurst @GVodyanov