Keep layout on sync errors #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6903 +/- ##
==========================================
+ Coverage 37.43% 38.31% +0.87%
==========================================
Files 939 925 -14
Lines 42404 42310 -94
Branches 1464 1466 +2
==========================================
+ Hits 15874 16210 +336
+ Misses 25753 25338 -415
+ Partials 777 762 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
af40cfd to
d9d2506
Compare
marcoambrosini
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Looks good @max-nextcloud, let's just make sure that the margin from the bottom is of size --clickable-area
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
2 times, most recently
from
bff0826 to
adc0bdb
Compare
|
/backport to stable30 |
|
/backport to stable29 |
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
adc0bdb to
f14eb27
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
2 times, most recently
from
678cd9e to
7e84bcc
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
The document status div is full width. Its background hides the text behind it and scrollbars on the side. Introduce a new .status-wrapper div that sets the background and only has the size of the actual message. Also move the message to the very bottom of the screen on mobile. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
7e84bcc to
51cb02c
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
51cb02c to
b47c6b5
Compare
|
@marcoambrosini This should be ready for another review. I have not added screenshots for small screens yet though. |
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
a555700 to
4beb32e
Compare
Otherwise unpacking the tar file failed on github runners if the cache was created by garm runners and the binary could not be found on garm runners if the cache was created by github runners. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
4beb32e to
64d9887
Compare
This was referenced Mar 12, 2025
|
ouch... did not remember that this was still on automerge. |
|
/backport to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6877
Ui changes
🖼️ Screenshots
Other commits
☑️ TODO
--clickable-area