Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable31] Keep layout on sync errors #6944

Open
wants to merge 10 commits into
base: stable31
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 12, 2025

Backport of PR #6903

The document status div is full width.
Its background hides the text behind it and scrollbars on the side.

Introduce a new .status-wrapper div that sets the background
and only has the size of the actual message.

Also move the message to the very bottom of the screen on mobile.

Signed-off-by: Max <[email protected]>
Otherwise unpacking the tar file failed on github runners
if the cache was created by garm runners
and the binary could not be found on garm runners
if the cache was created by github runners.

Signed-off-by: Max <[email protected]>
@backportbot backportbot bot requested a review from marcoambrosini March 12, 2025 11:29
@backportbot backportbot bot added bug Something isn't working 3. to review labels Mar 12, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.1 milestone Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 76.84211% with 22 lines in your changes missing coverage. Please review.

Project coverage is 47.39%. Comparing base (4c7fbff) to head (cc154a3).

Files with missing lines Patch % Lines
src/components/Editor/DocumentStatus.vue 0.00% 12 Missing ⚠️
...rc/components/Editor/DocumentStatus/SyncStatus.vue 91.25% 6 Missing and 1 partial ⚠️
src/components/Editor.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           stable31    #6944      +/-   ##
============================================
+ Coverage     46.51%   47.39%   +0.87%     
============================================
  Files           751      742       -9     
  Lines         34651    34698      +47     
  Branches       1270     1276       +6     
============================================
+ Hits          16118    16444     +326     
+ Misses        17910    17643     -267     
+ Partials        623      611      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants