Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Gateways - optimize reloading #3272

Open
Tracked by #1508
sjberman opened this issue Mar 27, 2025 · 0 comments
Open
Tracked by #1508

Multiple Gateways - optimize reloading #3272

sjberman opened this issue Mar 27, 2025 · 0 comments
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Milestone

Comments

@sjberman
Copy link
Collaborator

sjberman commented Mar 27, 2025

As a followup to the multiple gateway support story, we need to optimize how many config reloads and messages we are sending to agent.

In the initial implementation, any change results in NGF updating and sending every config (even if it's irrelevant). We should only send configuration to agent if it's changed.

Acceptance

  • NGF only sends configuration to an agent if the corresponding NGINX instance needs to be changed.
  • NGF only calls the NGINX Plus API if upstreams have changed

Dev Notes

  • Check the updateNginxConf workflow section in the internal design doc for details on how we can do this
  • Process() no longer needs to return the ChangeType variable.
@sjberman sjberman added the enhancement New feature or request label Mar 27, 2025
@sjberman sjberman added this to the v2.0.0 milestone Mar 27, 2025
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/medium Estimated to be completed within a week
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants