fix: propagate env var to nginx.conf in order to use IAM for Service Account properly #415
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Contribute to issue #414.
IAM credentials are not working, when the
awscredentials.js
script is trying to read the environmental variables, and those are not present. By this change, we propagate the environmental variables to nginx, and it will be possible to use the credentials provided by the SA accountChecklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md
).