upsertEntities misleading name

[strigefleur]

As per docs upsertEntities will perform a merge: Any partial entities will be merged with the existing ones.

So, you may end up in situation where the store contains

{ id: 1, permanentProp: 'alwaysHere', nullableProp: 'sometimesHere' }

and pending entity is

{ id: 1, permanentProp: 'alwaysHere123' }

and then upsertEntities merge both resulting in a false entity state

{ id: 1, permanentProp: 'alwaysHere123', nullableProp: 'sometimesHere' }

whereas expected entity state is

{ id: 1, permanentProp: 'alwaysHere123' }.

This works as intended as the documents say.

Though database experience tells it should not be I insert if not found, I merge if found but rather I insert if not found, I overwrite if found. Actual behavior sounds more like mergesert than upsert.

I'd suggest either rename the method to match it's purpose or add some kind of upsertStrategy = 'merge' | 'overwrite' as an option to the method call.