server/tests-py: Fix test_inconsistent_meta.py for split databases.

This test did not work when splitting the metadata and source backends. Fixed mostly by running the relevant SQL using `source_backend.engine`, but I also took the time to clean it up a little, and broke up _test.yaml_ into 3 files.

PR-URL: hasura/graphql-engine-mono#6957
GitOrigin-RevId: bbca60a8906caba2d0cffd834b3b8595fca058fd

Author: SamirTalwar

server/tests-py/queries/inconsistent_objects/expectation.yaml

@@ -0,0 +1,23 @@
+- definition:
+    schema: public
+    name: article
+  name: table article in source default
+  reason: 'Inconsistent object: no such table/view exists in source: "article"'
+  type: table
+- definition:
+    using:
+      foreign_key_constraint_on:
+        column: author_id
+        table:
+          schema: public
+          name: article
+    name: articles
+    source: default
+    comment:
+    table:
+      schema: public
+      name: author
+  name: array_relation articles in table author in source default
+  reason: >-
+    Inconsistent object: in table "author": in relationship "articles": table "article" does not exist in source: default
+  type: array_relation

server/tests-py/queries/inconsistent_objects/setup.yaml

@@ -0,0 +1,42 @@
+type: bulk
+args:
+# tables
+- type: run_sql
+  args:
+    sql: |
+      create table author(
+          id serial primary key,
+          name text unique
+      );
+      create table article(
+          id serial primary key,
+          title text not null,
+          content text,
+          author_id integer not null references author(id)
+      );
+- type: track_table
+  args:
+    schema: public
+    name: author
+- type: track_table
+  args:
+    schema: public
+    name: article
+
+#Object relationship
+- type: create_object_relationship
+  args:
+    table: article
+    name: author
+    using:
+      foreign_key_constraint_on: author_id
+
+#Array relationship
+- type: create_array_relationship
+  args:
+    table: author
+    name: articles
+    using:
+      foreign_key_constraint_on:
+        table: article
+        column: author_id

server/tests-py/queries/inconsistent_objects/teardown.yaml

@@ -0,0 +1,6 @@
+type: bulk
+args:
+- type: run_sql
+  args:
+    sql: |
+      drop table author

server/tests-py/queries/inconsistent_objects/test.yaml

@@ -1,47 +1,56 @@
-import pytest
 import json
 import jsondiff
 from ruamel.yaml import YAML
 
 yaml=YAML(typ='safe', pure=True)
 
+def load_yaml(path):
+    with open(path) as f:
+        return json.loads(json.dumps(yaml.load(f)))
+
 class TestInconsistentObjects():
 
     reload_metadata = {
         "type": "reload_metadata",
-        "args": {}
+        "args": {},
     }
     drop_inconsistent_metadata = {
         "type": "drop_inconsistent_metadata",
-        "args": {}
+        "args": {},
     }
     export_metadata = {
         "type": "export_metadata",
-        "args": {}
+        "args": {},
     }
 
-    def test_inconsistent_objects(self, hge_ctx):
-        with open(self.dir() + "/test.yaml") as c:
-            test = yaml.load(c)
+    def test_inconsistent_objects(self, hge_ctx, source_backend):
+        setup = load_yaml(self.dir() + "/setup.yaml")
+        expected_inconsistent_objects = load_yaml(self.dir() + "/expectation.yaml")
+        teardown = load_yaml(self.dir() + "/teardown.yaml")
 
-        # setup
-        resp = hge_ctx.v1q(json.loads(json.dumps(test['setup'])))
+        hge_ctx.v1q(setup)
 
         try:
             # exec sql to cause inconsistentancy
-            hge_ctx.sql(test['sql'])
+            # TODO: remove once parallelization work is completed
+            #       `source_backend` will no longer be optional
+            if source_backend:
+                with source_backend.engine.connect() as connection:
+                    connection.execute('drop table article')
+            else:
+                # this only works when the metadata database and the source database are the same
+                hge_ctx.sql('drop table article')
 
             # reload metadata
             resp = hge_ctx.v1q(q=self.reload_metadata)
             # check inconsistent objects
-            incons_objs_test = test['inconsistent_objects']
-            incons_objs_resp = resp['inconsistent_objects']
+            actual_inconsistent_objects = resp['inconsistent_objects']
 
             assert resp['is_consistent'] == False, resp
-            assert incons_objs_resp == incons_objs_test, yaml.dump({
-                'response': incons_objs_resp,
-                'expected': incons_objs_test,
-                'diff': jsondiff.diff(incons_objs_test, incons_objs_resp)
+            assert actual_inconsistent_objects == expected_inconsistent_objects, yaml.dump({
+                'response': actual_inconsistent_objects,
+                'expected': expected_inconsistent_objects,
+                'diff': jsondiff.diff(expected_inconsistent_objects, actual_inconsistent_objects)
             })
 
             # export metadata
@@ -51,9 +60,9 @@ def test_inconsistent_objects(self, hge_ctx):
             hge_ctx.v1q(
                 q={
                     "type": "replace_metadata",
-                    "args": export
+                    "args": export,
                 },
-                expected_status_code = 400
+                expected_status_code = 400,
             )
 
         finally:
@@ -65,8 +74,7 @@ def test_inconsistent_objects(self, hge_ctx):
             # check inconsistent objects
             assert resp['is_consistent'] == True, resp
 
-            # teardown
-            hge_ctx.v1q(json.loads(json.dumps(test['teardown'])))
+            hge_ctx.v1q(teardown)
 
     @classmethod
     def dir(cls):