Skip to content

Commit 4f38bf3

Browse files
committed
Add some comment regarding the minimal Python version and exclude all the venv* folders in the linter configuration
1 parent 6a08898 commit 4f38bf3

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

Diff for: CONTRIBUTING.md

+3-6
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ the developers managing and developing this open source project. In return,
1010
they should reciprocate that respect in addressing your issue or assessing
1111
patches and features.
1212

13-
1413
## Using the issue tracker
1514

1615
The [issue tracker](https://github.com/nicolargo/glances/issues) is
@@ -24,7 +23,6 @@ restrictions:
2423
* Please **do not** derail or troll issues. Keep the discussion on topic and
2524
respect the opinions of others.
2625

27-
2826
## Bug reports
2927

3028
A bug is a _demonstrable problem_ that is caused by the code in the repository.
@@ -65,19 +63,17 @@ Example:
6563
> causing the bug, and potential solutions (and your opinions on their
6664
> merits).
6765
>
68-
> You can also run Glances in debug mode (-d) and paste/bin the glances.conf file (https://glances.readthedocs.io/en/latest/config.html).
66+
> You can also run Glances in debug mode (-d) and paste/bin the glances.conf file (<https://glances.readthedocs.io/en/latest/config.html>).
6967
>
7068
> Glances 3.2.0 or higher have also a --issue option to run a simple test. Please use it and copy/paste the output.
7169
72-
7370
## Feature requests
7471

7572
Feature requests are welcome. But take a moment to find out whether your idea
76-
fits with the scope and aims of the project. It's up to *you* to make a strong
73+
fits with the scope and aims of the project. It's up to _you* to make a strong
7774
case to convince the project's developers of the merits of this feature. Please
7875
provide as much detail and context as possible.
7976

80-
8177
## Pull requests
8278

8379
Good pull requests—patches, improvements, new features—are a fantastic
@@ -133,6 +129,7 @@ included in the project:
133129

134130
5. Test you code using the Makefile:
135131

132+
* make format ==> Format your code thanks to the Ruff linter
136133
* make run ==> Run Glances
137134
* make run-webserver ==> Run a Glances Web Server
138135
* make test ==> Run unit tests

Diff for: pyproject.toml

+3
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ exclude = [
5858
"dist",
5959
"node_modules",
6060
"venv",
61+
"venv-dev",
62+
"venv-min",
6163
"docs",
64+
"test-data",
6265
"./glances/outputs/static/*"
6366
]
6467

Diff for: setup.py

+3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
from setuptools import Command, setup
1010

11+
# If the minimal Python version is changed then do not forget to change it in:
12+
# - ./pyproject.toml
13+
# - .github/workflows/test.yml
1114
if not (sys.version_info >= (3, 8)):
1215
print('Glances requires at least Python 3.8 to run.')
1316
sys.exit(1)

0 commit comments

Comments
 (0)