Skip to content

Commit c00383f

Browse files
authored
Merge pull request #3106 from almkuznetsov/config-dir
default_config_dir: Fix config path to include glances/ directory
2 parents 0c6c488 + bafe0e2 commit c00383f

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

docs/config.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ Location
1717
You can place your ``glances.conf`` file in the following locations:
1818

1919
==================== =============================================================
20-
``Linux``, ``SunOS`` ~/.config/glances/, /etc/glances/, /usr/share/docs/glances/
21-
``*BSD`` ~/.config/glances/, /usr/local/etc/glances/, /usr/share/docs/glances/
22-
``macOS`` ~/.config/glances/, ~/Library/Application Support/glances/, /usr/local/etc/glances/, /usr/share/docs/glances/
20+
``Linux``, ``SunOS`` ~/.config/glances/, /etc/glances/, /usr/share/doc/glances/
21+
``*BSD`` ~/.config/glances/, /usr/local/etc/glances/, /usr/share/doc/glances/
22+
``macOS`` ~/.config/glances/, ~/Library/Application Support/glances/, /usr/local/etc/glances/, /usr/share/doc/glances/
2323
``Windows`` %APPDATA%\\glances\\glances.conf
2424
``All`` + <venv_root_folder>/share/doc/glances/
2525
==================== =============================================================

docs/man/glances.1

+3-3
Original file line numberDiff line numberDiff line change
@@ -565,19 +565,19 @@ l|l.
565565
T{
566566
\fBLinux\fP, \fBSunOS\fP
567567
T} T{
568-
~/.config/glances/, /etc/glances/, /usr/share/docs/glances/
568+
~/.config/glances/, /etc/glances/, /usr/share/doc/glances/
569569
T}
570570
_
571571
T{
572572
\fB*BSD\fP
573573
T} T{
574-
~/.config/glances/, /usr/local/etc/glances/, /usr/share/docs/glances/
574+
~/.config/glances/, /usr/local/etc/glances/, /usr/share/doc/glances/
575575
T}
576576
_
577577
T{
578578
\fBmacOS\fP
579579
T} T{
580-
~/.config/glances/, ~/Library/Application Support/glances/, /usr/local/etc/glances/, /usr/share/docs/glances/
580+
~/.config/glances/, ~/Library/Application Support/glances/, /usr/local/etc/glances/, /usr/share/doc/glances/
581581
T}
582582
_
583583
T{

glances/config.py

+10-8
Original file line numberDiff line numberDiff line change
@@ -81,18 +81,20 @@ def default_config_dir():
8181
- Linux, SunOS, *BSD, macOS: /usr/share/doc (as defined in the setup.py files)
8282
- Windows: %APPDATA%\glances
8383
"""
84-
path = []
85-
# Add venv path (solve issue #2803)
86-
if in_virtualenv():
87-
path.append(os.path.join(sys.prefix, 'share', 'doc', 'glances'))
84+
paths = []
8885

89-
# Add others system path
86+
# Add system path
9087
if LINUX or SUNOS or BSD or MACOS:
91-
path.append('/usr/share/doc')
88+
paths.append(os.path.join(sys.prefix, 'share', 'doc'))
9289
else:
93-
path.append(os.environ.get('APPDATA'))
90+
paths.append(os.environ.get('APPDATA'))
9491

95-
return path
92+
# If we are in venv (issue #2803), sys.prefix != sys.base_prefix and we
93+
# already added venv path with sys.prefix. Add base_prefix path too
94+
if in_virtualenv():
95+
paths.append(os.path.join(sys.base_prefix, 'share', 'doc'))
96+
97+
return [os.path.join(path, 'glances') if path is not None else '' for path in paths]
9698

9799

98100
def in_virtualenv():

0 commit comments

Comments
 (0)