Skip to content

Commit 6173a48

Browse files
committed
wip
1 parent 2f08950 commit 6173a48

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

Zend/zend_vm_def.h

-1
Original file line numberDiff line numberDiff line change
@@ -3153,7 +3153,6 @@ ZEND_VM_HOT_HANDLER(127, ZEND_FE_FREE, TMPVAR, ANY)
31533153
if (Z_FE_ITER_P(var) != (uint32_t)-1) {
31543154
zend_hash_iterator_del(Z_FE_ITER_P(var));
31553155
}
3156-
//zval_ptr_dtor_nogc(var);
31573156
zval_ptr_dtor(var);
31583157
ZEND_VM_NEXT_OPCODE_CHECK_EXCEPTION();
31593158
}

Zend/zend_vm_execute.h

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/intl/common/common_enum.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ void zoi_with_current_dtor(zend_object_iterator *iter)
5050

5151
if (!Z_ISUNDEF(zoiwc->wrapping_obj)) {
5252
/* we have to copy the pointer because zoiwc->wrapping_obj may be
53-
* changed midway the execution of zval_ptr_dtor() */
53+
* changed midway the execution of zval_ptr_dtor() */
5454
zval *zwo = &zoiwc->wrapping_obj;
5555

5656
/* object is still here, we can rely on it to call this again and
@@ -196,13 +196,14 @@ static HashTable *IntlIterator_get_gc(zend_object *object, zval **table, int *n)
196196
if (ii->iterator) {
197197
zend_get_gc_buffer *gc = zend_get_gc_buffer_create();
198198
zend_get_gc_buffer_add_obj(gc, &ii->iterator->std);
199+
/* current can't participate in a cycle */
199200
zend_get_gc_buffer_use(gc, table, n);
200201
} else {
201202
*table = NULL;
202203
*n = 0;
203204
}
204205

205-
return NULL;
206+
return zend_std_get_properties(object);
206207
}
207208

208209
static zend_object_iterator *IntlIterator_get_iterator(

0 commit comments

Comments
 (0)