Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the luigi-own configuration #31

Open
nils-braun opened this issue Apr 16, 2020 · 3 comments
Open

Use the luigi-own configuration #31

nils-braun opened this issue Apr 16, 2020 · 3 comments

Comments

@nils-braun
Copy link
Owner

Instead of relying on our own settings implementation, we can also leverage the luigi configuration

@meliache
Copy link
Collaborator

This has my upvote, I would much prefer using the toml supported by luigi over json, especially for the ability to add comments to settings, as long as per default the old json format would still work.

@welschma
Copy link
Contributor

Is your idea to add an additional way to read in settings via the luigi.cfg (or luigi.toml) file or a total reimplementation of the settings handling? i think the former could easily be implemented like this.

@nils-braun nils-braun changed the title Use the luigi-own configuratoin Use the luigi-own configuration Apr 20, 2020
@nils-braun
Copy link
Owner Author

Good question.
I think the long term goal we need to tackle at some point is to bring many of our developments to the upstream repository.
For that, I would like to get rid of our custom settings logic - but keep the interface for backwards compatibility.
But you both made a good point: using toml instead of json is already better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants