You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has my upvote, I would much prefer using the toml supported by luigi over json, especially for the ability to add comments to settings, as long as per default the old json format would still work.
Is your idea to add an additional way to read in settings via the luigi.cfg (or luigi.toml) file or a total reimplementation of the settings handling? i think the former could easily be implemented like this.
nils-braun
changed the title
Use the luigi-own configuratoin
Use the luigi-own configuration
Apr 20, 2020
Good question.
I think the long term goal we need to tackle at some point is to bring many of our developments to the upstream repository.
For that, I would like to get rid of our custom settings logic - but keep the interface for backwards compatibility.
But you both made a good point: using toml instead of json is already better
Instead of relying on our own settings implementation, we can also leverage the luigi configuration
The text was updated successfully, but these errors were encountered: